NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-128961: Fix exhausted array iterator crash in`setstate`#128962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 7 commits intopython:mainfromtom-pytel:fix-issue-128961

Jan 18, 2025

Merged

gh-128961: Fix exhausted array iterator crash in`setstate`#128962

erlend-aasland merged 7 commits intopython:mainfromtom-pytel:fix-issue-128961

Jan 18, 2025

Conversation

Copy link

Contributor

tom-pytel commentedJan 17, 2025•
edited by bedevere-appbot
Loading

Simple fix for this segfault.

Issue:array iterator segfault on __setstate__() when exhausted #128961

pythongh-128961: fix array iterator segfault on __setstate__

7831074

bedevere-appbot mentioned this pull request

Jan 17, 2025

array iterator segfault on __setstate__() when exhausted#128961

Closed

Copy link

bedevere-appbot commentedJan 17, 2025

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

bedevere-appbot added the awaiting review label

Jan 17, 2025

Copy link

bedevere-appbot commentedJan 17, 2025

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

tom-pyteland others added2 commits

January 17, 2025 16:32

oops

3975683

📜🤖 Added by blurb_it.

3f9bd66

sobolevn reviewed

Jan 17, 2025

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

style nit :)

Modules/arraymodule.c OutdatedShow resolvedHide resolved

nit picked

e7f00dc

tomasr8 reviewed

Jan 17, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-01-17-21-33-11.gh-issue-128961.XwvyIZ.rst OutdatedShow resolvedHide resolved

upgrade words

d6610b7

tomasr8 approved these changes

Jan 17, 2025

View reviewed changes

bedevere-appbot added awaiting core review and removed awaiting review labels

Jan 17, 2025

Copy link

Contributor

erlend-aasland commentedJan 17, 2025

Thanks,@tom-pytel!

erlend-aasland reviewed

Jan 17, 2025

View reviewed changes

Lib/test/test_array.pyShow resolvedHide resolved

test raise StopIteration afterpythongh-128961

8eab735

erlend-aasland reviewed

Jan 17, 2025

View reviewed changes

Lib/test/test_array.py OutdatedShow resolvedHide resolved

requested tweaks

2accb87

erlend-aasland approved these changes

Jan 18, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Jan 18, 2025

erlend-aasland added needs backport to 3.12

only security fixes

needs backport to 3.13bugs and security fixes labels

Jan 18, 2025

picnixz reviewed

Jan 18, 2025

View reviewed changes

Modules/arraymodule.cShow resolvedHide resolved

picnixz approved these changes

Jan 18, 2025

View reviewed changes

Copy link

Contributor

erlend-aasland commentedJan 18, 2025

@sobolevn'sPEP-7 remarks were addressed withe7f00dc. Looks like we're good to go. Thanks a lot,@tom-pytel!

erlend-aasland changed the title~~gh-128961: fix exhausted array iterator crash on __setstate__~~gh-128961: Fix exhausted array iterator crash in__setstate__

Jan 18, 2025

erlend-aasland merged commit4dade05 intopython:main

Jan 18, 2025

49 checks passed

This comment was marked as outdated.

bedevere-appbot removed the awaiting merge label

Jan 18, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 18, 2025

pythongh-128961: Fix exhausted array iterator crash in __setstate__() (…

29cbdab

…pythonGH-128962)(cherry picked from commit4dade05)Co-authored-by: Tomasz Pytel <tompytel@gmail.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 18, 2025

pythongh-128961: Fix exhausted array iterator crash in __setstate__() (…

bf59715

…pythonGH-128962)(cherry picked from commit4dade05)Co-authored-by: Tomasz Pytel <tompytel@gmail.com>

Copy link

bedevere-appbot commentedJan 18, 2025

GH-128976 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

Jan 18, 2025

Copy link

bedevere-appbot commentedJan 18, 2025

GH-128977 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Jan 18, 2025

erlend-aasland pushed a commit that referenced this pull request

Jan 18, 2025

[3.12]gh-128961: Fix exhausted array iterator crash in __setstate__() (

405f6d7

GH-128962) (#128977)(cherry picked from commit4dade05)Co-authored-by: Tomasz Pytel <tompytel@gmail.com>

erlend-aasland pushed a commit that referenced this pull request

Jan 18, 2025

[3.13]gh-128961: Fix exhausted array iterator crash in __setstate__() (

c75894a

GH-128962) (#128976)(cherry picked from commit4dade05)Co-authored-by: Tomasz Pytel <tompytel@gmail.com>

This comment was marked as off-topic.

Copy link

Member

ZeroIntensity commentedJan 18, 2025•
edited
Loading

@tom-pytel Is this your first merged PR? If so, congrats! (The buildbot failure is unrelated, FWIW.)

Copy link

ContributorAuthor

tom-pytel commentedJan 18, 2025

@tom-pytel Is this your first merged PR? If so, congrats! (The buildbot failure is unrelated, FWIW.)

Yup, first official PR so thank you. I did python internals at at a company a couple years back so not my first cpython rodeo, but free-threading and the quickening/specialization stuff is new.