Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-63882: Comment out emptytest_minidom tests#128948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
srinivasreddy wants to merge6 commits intopython:main
base:main
Choose a base branch
Loading
fromsrinivasreddy:gh-19683-comment-empty-tests

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddysrinivasreddy commentedJan 17, 2025
edited by terryjreedy
Loading

Given the absence of immediate replacements, this was considered better than deletion.

@bedevere-appbedevere-appbot added testsTests in the Lib/test dir awaiting review labelsJan 17, 2025
@srinivasreddy
Copy link
ContributorAuthor

srinivasreddy commentedJan 17, 2025
edited
Loading

This is the second item from the action items proposed by@terryjreedy (#63882 (comment))

  1. Minidom docstrings issue gh-128508: Add some docstrings to xml.dom.minidom #128477
  2. Comment out the empty testsgh-63882: Comment out emptytest_minidom tests #128948
  3. Test revisions - to be addressed in later pr

@srinivasreddysrinivasreddy changed the titlegh-19683: Comment out empty testsgh-63882: Comment out empty testsJan 17, 2025
@StanFromIreland
Copy link
Contributor

@terryjreedy (I can’t request a review in any other way)

Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think all of them are included. Looks good to me!

@picnixz
Copy link
Member

Why are we using## instead of a simple# for commenting out the test? Is there any plan of actually implementing those tests in the future? can we add some# TODO as well so that we can find them easily in the future?

@StanFromIreland
Copy link
Contributor

@picnixz This was requested by Terry in his comment on the issue. I guess it is easier to find them?

@picnixzpicnixz changed the titlegh-63882: Comment out empty testsgh-63882: Comment out emptytest_minidom testsJan 17, 2025
@picnixz
Copy link
Member

I think I'll me comfortable with an explicit "TODO" since we also used# CRASH for the test C API to make them easier to find (with a##, we need to filter out the results but with# TODO, we know that's a TODO).


Ok, I've seen that#63882 (comment) is actually the comment that explained the different steps to do (it was hidden by GH). So there's a plan to implement something. If the tests are meant to be implemented in a short future,## is fine, but if it's not, then maybe# TODO is better.

Copy link
Member

@terryjreedyterryjreedy left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Double hashes, '##', are an old standard for (temporarily) commenting out code with something other than normal code comments. I added a "# TODO" comment.

picnixz and srinivasreddy reacted with heart emoji
Copy link
Member

@terryjreedyterryjreedy left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Make the first 3 tests 1 line as with all the others.

@hugovk
Copy link
Member

hugovk commentedApr 24, 2025
edited
Loading

These stubs have been present for 25 years, since Python 2.0!
7993bcc

I'd rather see tests added rather than commented out. If not added, let's delete them otherwise I can see these being around until 2050 🙃

Quoting@voidspace:

The same is true for commenting-out code; if a block of commented code is going into a release, it shouldn't exist. If it is code that may be restored, make a ticket and reference the commit hash for the code delete.

https://opensource.com/article/17/5/30-best-practices-software-development-and-testing

@StanFromIreland
Copy link
Contributor

There is actually already a patch that would add some of them:https://bugs.python.org/file33258/issue19683.patch

Tough I am not sure who submitted it.

@hugovk
Copy link
Member

Maybe checking the old bpo page helps?

https://bugs.python.org/issue19683

Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some of these tests have been implemented. Surprisingly not a merge conflict.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@terryjreedyterryjreedyterryjreedy left review comments

@StanFromIrelandStanFromIrelandStanFromIreland requested changes

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
awaiting mergeskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@srinivasreddy@StanFromIreland@picnixz@hugovk@terryjreedy

[8]ページ先頭

©2009-2025 Movatter.jp