Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
bpo-32424: Improve test coverage for xml.etree.ElementTree#12891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
GPHemsley commentedApr 20, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@serhiy-storchaka@scoder Can you review these with fresh eyes? I haven't necessarily attempted to address comments from the previous PR, but I want to make sure we at least have a separation of concerns. |
scoder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The comments fromGH-5046 still apply.
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedApr 21, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
GPHemsley commentedApr 21, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
scoder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added the comments that I think still apply.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fec9b9b to8f4adcdCompareGPHemsley commentedApr 21, 2019 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading.Please reload this page.
8f4adcd to96e6599CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
96e6599 to7338f47Compare
GPHemsley left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Addressed comments.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
GPHemsley commentedApr 27, 2019
I have made the requested changes; please review again. |
bedevere-bot commentedApr 27, 2019
Thanks for making the requested changes! @scoder: please review the changes made to this pull request. |
scoder commentedApr 28, 2019
Thanks. |
GPHemsley commentedApr 28, 2019
Thanks for sticking with this! |
Uh oh!
There was an error while loading.Please reload this page.
(Spun off from#5046.)
Add unit tests to improve coverage for xml.etree.ElementTree.
According to my testing, these should all pass in both the C and Python implementations of ElementTree.
https://bugs.python.org/issue32424