Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-32424: Improve test coverage for xml.etree.ElementTree#12891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
scoder merged 2 commits intopython:masterfromGPHemsley:improve-xml-etree-tests
Apr 28, 2019

Conversation

@GPHemsley
Copy link
Contributor

@GPHemsleyGPHemsley commentedApr 20, 2019
edited by bedevere-bot
Loading

(Spun off from#5046.)

Add unit tests to improve coverage for xml.etree.ElementTree.

According to my testing, these should all pass in both the C and Python implementations of ElementTree.

https://bugs.python.org/issue32424

@GPHemsley
Copy link
ContributorAuthor

GPHemsley commentedApr 20, 2019
edited
Loading

@serhiy-storchaka@scoder Can you review these with fresh eyes? I haven't necessarily attempted to address comments from the previous PR, but I want to make sure we at least have a separation of concerns.

Copy link
Contributor

@scoderscoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The comments fromGH-5046 still apply.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@GPHemsley
Copy link
ContributorAuthor

GPHemsley commentedApr 21, 2019
edited
Loading

The comments fromGH-5046 still apply.

I was hoping to get them fresh here to ensure that discussions didn't get conflated. (Note that I removed tests that would fail due to the other issues discussed in#5046 and elsewhere.)

Copy link
Contributor

@scoderscoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added the comments that I think still apply.

@scoderscoder changed the titleImprove test coverage for xml.etree.ElementTreebpo-32424: Improve test coverage for xml.etree.ElementTreeApr 21, 2019
@GPHemsleyGPHemsleyforce-pushed theimprove-xml-etree-tests branch fromfec9b9b to8f4adcdCompareApril 21, 2019 21:36
@GPHemsley
Copy link
ContributorAuthor

GPHemsley commentedApr 21, 2019
edited by bedevere-bot
Loading

@scoder Note that I explicitly did not include an issue number on this PR because it is not directly tied to any issue and does not resolve any open tickets. Rather, it is a prerequisite to my changes for bothbpo-32424 andbpo-36685.

@GPHemsleyGPHemsleyforce-pushed theimprove-xml-etree-tests branch from8f4adcd to96e6599CompareApril 21, 2019 21:55
@GPHemsleyGPHemsleyforce-pushed theimprove-xml-etree-tests branch from96e6599 to7338f47CompareApril 27, 2019 19:21
Copy link
ContributorAuthor

@GPHemsleyGPHemsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Addressed comments.

@GPHemsley
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@scoder: please review the changes made to this pull request.

@scoder
Copy link
Contributor

Thanks.

@scoderscoder merged commit50fed0b intopython:masterApr 28, 2019
@GPHemsley
Copy link
ContributorAuthor

Thanks for sticking with this!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@scoderscoderscoder approved these changes

Assignees

No one assigned

Labels

testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GPHemsley@bedevere-bot@scoder@serhiy-storchaka@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp