Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128770: fix ResourceWarning in test_pyrepl#128906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

graingert
Copy link
Contributor

@graingertgraingert commentedJan 16, 2025•
edited by bedevere-appbot
Loading

@graingertgraingertforce-pushed thefix-resource-warning-in-test-pyrepl branch from4536f9c toca5eb67CompareJanuary 16, 2025 07:31
@graingertgraingert changed the titlegh-110012: FixRuntimeWarning intest_socketgh-128770: fix ResourceWarning in test_pyreplJan 16, 2025
@graingertgraingert marked this pull request as ready for reviewJanuary 16, 2025 07:58
@graingertgraingert added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 16, 2025
@pablogsalpablogsal merged commit24c84d8 intopython:mainJan 22, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks@graingert for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 22, 2025
(cherry picked from commit24c84d8)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@miss-islington-app
Copy link

Sorry,@graingert and@pablogsal, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 24c84d816f2f2ecb76b80328c3f1d8c05ead0b10 3.12

@bedevere-app
Copy link

GH-129179 is a backport of this pull request to the3.13 branch.

@pablogsal
Copy link
Member

The new REPL is only on 3.13 so the 3.12 backport is not needed :)

@graingertgraingert deleted the fix-resource-warning-in-test-pyrepl branchJanuary 22, 2025 12:50
@graingert
Copy link
ContributorAuthor

Oh whoops

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

@hugovkhugovkAwaiting requested review from hugovk

Assignees

@pablogsalpablogsal

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@graingert@pablogsal@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp