Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] gh-71339: Add additional assertion methods in test.support (GH-128707)#128815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 14, 2025
edited by bedevere-appbot
Loading

Add a mix-in class ExtraAssertions containing the following methods:

  • assertHasAttr() and assertNotHasAttr()
  • assertIsSubclass() and assertNotIsSubclass()
  • assertStartsWith() and assertNotStartsWith()
  • assertEndsWith() and assertNotEndsWith()

(cherry picked from commit06cad77)

This will help to backport new tests that use new assertion methods.

@serhiy-storchakaserhiy-storchaka added testsTests in the Lib/test dir skip news needs backport to 3.12only security fixes labelsJan 14, 2025
@serhiy-storchakaserhiy-storchaka changed the titlegh-71339: Add additional assertion methods in test.support (GH-128707)[3.13] gh-71339: Add additional assertion methods in test.support (GH-128707)Jan 14, 2025
…honGH-128707)Add a mix-in class ExtraAssertions containing the following methods:* assertHasAttr() and assertNotHasAttr()* assertIsSubclass() and assertNotIsSubclass()* assertStartsWith() and assertNotStartsWith()* assertEndsWith() and assertNotEndsWith()(cherry picked from commit06cad77)
@serhiy-storchakaserhiy-storchaka merged commitc6a566e intopython:3.13Jan 20, 2025
36 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the extra-assertions-3.13 branchJanuary 20, 2025 09:19
@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker c6a566e47b9903d48e6e1e78a1af20e6c6c535cf 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJan 20, 2025
…t.support (pythonGH-128707) (pythonGH-128815)Add a mix-in class ExtraAssertions containing the following methods:* assertHasAttr() and assertNotHasAttr()* assertIsSubclass() and assertNotIsSubclass()* assertStartsWith() and assertNotStartsWith()* assertEndsWith() and assertNotEndsWith()(cherry picked from commitc6a566e)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>(cherry picked from commit06cad77)
@bedevere-app
Copy link

GH-129059 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 20, 2025
serhiy-storchaka added a commit that referenced this pull requestJan 20, 2025
…-128707) (GH-128815) (GH-129059)Add a mix-in class ExtraAssertions containing the following methods:* assertHasAttr() and assertNotHasAttr()* assertIsSubclass() and assertNotIsSubclass()* assertStartsWith() and assertNotStartsWith()* assertEndsWith() and assertNotEndsWith()(cherry picked from commitc6a566e)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>(cherry picked from commit06cad77)
@@ -28,7 +29,7 @@ def anchor02(self):
return importlib.import_module('data02')


class FunctionalAPIBase(util.DiskSetup):
class FunctionalAPIBase(util.DiskSetup, ExtraAssertions):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The change in this file is going to be overwritten unless ported over to importlib_resources (and backported to support Python 3.9).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jaracojaracojaraco left review comments

@vstinnervstinnerAwaiting requested review from vstinner

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@serhiy-storchaka@jaraco

[8]ページ先頭

©2009-2025 Movatter.jp