Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-128520: Subclassabc.ABC inpathlib._abc#128745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
barneygale merged 12 commits intopython:mainfrombarneygale:grown-up-abcs
Feb 16, 2025

Conversation

barneygale
Copy link
Contributor

@barneygalebarneygale commentedJan 11, 2025•
edited by bedevere-appbot
Loading

ConvertJoinablePath,ReadablePath andWritablePath to real ABCs derived fromabc.ABC.

MakeJoinablePath.parser abstract, rather than defaulting toposixpath.

RegisterPurePath andPath as virtual subclasses of the ABCs rather than deriving. This avoids a hit to path object instantiation performance.

No change of behaviour in the public (non-abstract) classes.

Convert `JoinablePath`, `ReadablePath` and `WritablePath` to real ABCsderived from `abc.ABC`.Make `JoinablePath.parser` abstract, rather than defaulting to `posixpath`.Register `PurePath` and `Path` as virtual subclasses of the ABCs ratherthan deriving. This avoids a hit to path object instantiation performance.
@barneygalebarneygale marked this pull request as draftJanuary 22, 2025 22:42
@barneygalebarneygale marked this pull request as ready for reviewFebruary 9, 2025 12:42
@barneygalebarneygaleenabled auto-merge (squash)February 16, 2025 00:10
@barneygalebarneygale merged commita7d41a8 intopython:mainFeb 16, 2025
38 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 LTO 3.x has failed when building commita7d41a8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/338/builds/8082) and take a look at the build logs.
  4. Check if the failure is related to this commit (a7d41a8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/338/builds/8082

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1054, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line996, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line47, inrun    interp= interpreters.create()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@barneygale@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp