Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-128639: Don't assume one thread in subinterpreter finalization#128640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 17 commits intopython:mainfromZeroIntensity:subinterpreter-thread-shutdownMay 19, 2025
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
17 commits Select commitHold shift + click to select a range
025cc17 Fix subinterpreter cleanup.
ZeroIntensityeea3ba9 Add and fix tests.
ZeroIntensity149e0cf Add blurb
ZeroIntensity1761c37 Fix threading tests.
ZeroIntensity8febfbf Fix test_embed.
ZeroIntensity5a73ce1 Remove buggy test.
ZeroIntensitya7cc3fe Skip flaky test.
ZeroIntensity7c44c0b Add an assertion.
ZeroIntensity6551bfa Remove stray newline.
ZeroIntensityf19e28d Add another assertion.
ZeroIntensity02da72a Merge branch 'main' into subinterpreter-thread-shutdown
ZeroIntensitya759540 Merge branch 'main' of https://github.com/python/cpython into subinte…
ZeroIntensity76e4ec9 Use new is_after_fork parameter
ZeroIntensity1555731 Apply suggestions from code review
ZeroIntensityd61099e Move call to finalize_subinterpreters()
ZeroIntensity09851dc Unskip the threading test.
ZeroIntensityb223396 Add a comment for the test.
ZeroIntensityFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Add blurb
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit149e0cf43b76c20eae699d3d0532c98c2b87f57b
There are no files selected for viewing
1 change: 1 addition & 0 deletionsMisc/NEWS.d/next/Core_and_Builtins/2025-01-08-12-52-47.gh-issue-128640.9nbh9z.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix a crash when using threads inside of a subinterpreter. |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.