Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-115776: RenamePy_TPFLAGS_INLINE_VALUES as_Py_TPFLAGS_INLINE_VALUES#128635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ould not be used by third-party code.
There are 2 package using this, but otherwise LGTMhttps://grep.app/search?q=Py_TPFLAGS_INLINE_VALUES |
That's unfortunate. I still think we are better off moving it, as any code using it (except for tools like PySpy) is broken. |
Yeah I realised their usage is wrong. Don't think it's even safe to unset the flag after it's been set. |
How do you check whether a type uses this layout (as inJPype)? The code in JPype is a workaround for earlier breakage. Is there a clean way to do what they need? |
Probably too late to get any code changes in for 3.14, and maybe too late to remove it for 3.15. |
Uh oh!
There was an error while loading.Please reload this page.
The
Py_TPFLAGS_INLINE_VALUESshould not be used when declaring a staticPyTypeObject. It can only be used by the VM when creating a class. It is undocumented, but is exposed inobject.h.This PR adds an underscore prefix to the name to make it clearer that this flag is internal.