Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-97850: Remove the mention of removal fromResourceReader docs#128602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaraco merged 1 commit intopython:mainfromtomasr8:importlib-resource-reader
Jan 8, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedJan 7, 2025•
edited by github-actionsbot
Loading

There is currently no plan to removeResourceReader, especially given that the suggested alternativeTraversableResources inherits fromResourceReader. Let's remove the mention of a removal for now.

Related discussion:#97850 (comment)

📚 Documentation preview 📚:https://cpython-previews--128602.org.readthedocs.build/

@hugovk
Copy link
Member

Also remove mention of removal fromhttps://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?

tomasr8 reacted with thumbs up emoji

@tomasr8
Copy link
MemberAuthor

Also remove mention of removal fromhttps://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?

Yes, I missed that one. I'll update the PR in a bit!

hugovk reacted with thumbs up emoji

@StanFromIreland
Copy link
Contributor

@tomasr8
Copy link
MemberAuthor

Oh wait, that is the otherResourceReader thatwas actually removed in 3.14 (fromimportlib.abc). This PR updates the one inimportlib.resources.abc which still exists. So there should be no need to update that document you mentioned Hugo.

Sorry for the confusion@StanFromIreland, I should've checked better :/ but thanks for the help!

StanFromIreland, jaraco, and hugovk reacted with thumbs up emoji

@brettcannonbrettcannon removed their request for reviewJanuary 8, 2025 21:00
@tomasr8tomasr8 requested a review fromjaracoJanuary 8, 2025 22:12
@jaracojaraco merged commita1284e9 intopython:mainJan 8, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2025
…ocs (pythonGH-128602)Remove the mention of removal from ResourceReader docs(cherry picked from commita1284e9)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2025
…ocs (pythonGH-128602)Remove the mention of removal from ResourceReader docs(cherry picked from commita1284e9)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-128654 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 8, 2025
@bedevere-app
Copy link

GH-128655 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 8, 2025
@bedevere-bot

This comment was marked as off-topic.

@tomasr8
Copy link
MemberAuthor

The buildbot failure is unrelated (it's intest_multiprocessing_forkserver while this PR only touches the docs)

ambv pushed a commit that referenced this pull requestJan 23, 2025
…docs (GH-128602) (#128654)gh-97850: Remove the mention of removal from `ResourceReader` docs (GH-128602)Remove the mention of removal from ResourceReader docs(cherry picked from commita1284e9)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Yhg1s pushed a commit that referenced this pull requestFeb 3, 2025
…docs (GH-128602) (#128655)gh-97850: Remove the mention of removal from `ResourceReader` docs (GH-128602)Remove the mention of removal from ResourceReader docs(cherry picked from commita1284e9)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jaracojaracojaraco approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@tomasr8@hugovk@StanFromIreland@bedevere-bot@jaraco
[8]ページ先頭
©2009-2025 Movatter.jp