NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-127146: Strip dash from Emscripten compiler version#128557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

freakboy3742 merged 1 commit intopython:mainfromhoodmane:emscripten-no-dash-in-version

Jan 6, 2025

Merged

gh-127146: Strip dash from Emscripten compiler version#128557

freakboy3742 merged 1 commit intopython:mainfromhoodmane:emscripten-no-dash-in-version

Jan 6, 2025

Conversation

Copy link

Contributor

hoodmane commentedJan 6, 2025•
edited by bedevere-appbot
Loading

emcc -dumpversion will sometimes say e.g.,4.0.0-git but in this case uname does not include-git in the version string. Use cut to delete everything after the dash.
cc@kleisauke

Issue:Emscripten: Get test suite passing #127146

pythongh-127146: Strip dash from Emscripten compiler version

272ad5c

`emcc -dumpversion` will sometimes say e.g., `4.0.0-git` but in this caseuname does not include `-git` in the version string. Use cut to deleteeverything after the dash.

hoodmane requested a review fromfreakboy3742

January 6, 2025 19:19

hoodmane requested review fromerlend-aasland andcorona10 ascode owners

January 6, 2025 19:19

bedevere-appbot mentioned this pull request

Jan 6, 2025

Emscripten: Get test suite passing#127146

Open

bedevere-appbot added the awaiting review label

Jan 6, 2025

hoodmane added the skip news label

Jan 6, 2025

erlend-aasland approved these changes

Jan 6, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels

Jan 6, 2025

freakboy3742 approved these changes

Jan 6, 2025

View reviewed changes

Copy link

Contributor

freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

freakboy3742 merged commit61c1a24 intopython:main

Jan 6, 2025

47 checks passed

bedevere-appbot removed the awaiting merge label

Jan 6, 2025

hoodmane deleted the emscripten-no-dash-in-version branch

January 7, 2025 16:04

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

Jan 8, 2025

pythongh-127146: Strip dash from Emscripten compiler version (python#…

6834b69

…128557)`emcc -dumpversion` will sometimes say e.g., `4.0.0-git` but in this caseuname does not include `-git` in the version string. Use cut to deleteeverything after the dash.