Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127146: Fix test_sysconfidata_json in Emscripten#128545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
hoodmane wants to merge1 commit intopython:mainfromhoodmane:sysconfig-test

Conversation

hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedJan 6, 2025•
edited by bedevere-appbot
Loading

In emscripten, the prefix is different when we build and generate the json file from when we run the test.

The prefix is different when we build from when we run the test.
@bedevere-appbedevere-appbot added the testsTests in the Lib/test dir labelJan 6, 2025
@hoodmanehoodmane requested review fromfreakboy3742 and removed request forFFY00January 6, 2025 12:58
@FFY00
Copy link
Member

The prefixes should be loaded from theMakefile when cross-compiling, which we detect from_PYTHON_PROJECT_BASE being set, which should be the case inmake test.

Doessys.base_prefix ever differ from theMakefile value? I am not entirely sure how the Python "installation" works on Emscripten's virtual file system. Can it be present/mounted/installed(?) on a directory other than the one specified in theMakefile? If so, and if that's where this problem stems from, then this isn't an issue specific to Emscripten, but rather all relocatable installations, which is something this test currently does not account for, but it probably should. If this is the problem, then I'd prefer to fix the underlying issue rather than special-case Emscripten.

@hoodmane
Copy link
ContributorAuthor

hoodmane commentedJan 6, 2025•
edited
Loading

I think I found the problem.

@hoodmane
Copy link
ContributorAuthor

Opened#128556 with an actual fix.

@hoodmanehoodmane deleted the sysconfig-test branchJanuary 6, 2025 19:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742Awaiting requested review from freakboy3742

Assignees
No one assigned
Labels
awaiting reviewskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hoodmane@FFY00
[8]ページ先頭
©2009-2025 Movatter.jp