Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-128472: Add-skip-funcs to BOLT options to fix computed goto errors#128511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
cc@aaupov You may be interested in this issue as the CPython use-case.. :) |
| dnl At least LLVM 19.x doesn't support computed gotos in PIC compiled code. | ||
| dnl Exclude functions containing computed gotos. | ||
| dnl TODO this may be fixed in LLVM 20.x via https://github.com/llvm/llvm-project/pull/120267. | ||
| [-skip-funcs=_PyEval_EvalFrameDefault,sre_ucs1_match/1,sre_ucs2_match/1,sre_ucs4_match/1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Now we have reasons to add CI to maintain this list actively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ref#128515
24b147a intopython:mainUh oh!
There was an error while loading.Please reload this page.
…to errors (pythongh-128511)* Add `-skip-funcs` to BOLT options to fix computed goto errorsCo-authored-by: Gregory Szorc <gregory.szorc@gmail.com>* NEWS---------(cherry picked from commit24b147a)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
…to errors (pythongh-128511)* Add `-skip-funcs` to BOLT options to fix computed goto errorsCo-authored-by: Gregory Szorc <gregory.szorc@gmail.com>* NEWS---------(cherry picked from commit24b147a)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
GH-128572 is a backport of this pull request to the3.12 branch. |
GH-128573 is a backport of this pull request to the3.13 branch. |
…oto errors (gh-128511) (gh-128572)gh-128472: Add `-skip-funcs` to BOLT options to fix computed goto errors (gh-128511)* Add `-skip-funcs` to BOLT options to fix computed goto errors* NEWS---------(cherry picked from commit24b147a)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
…oto errors (gh-128511) (#128573)gh-128472: Add `-skip-funcs` to BOLT options to fix computed goto errors (gh-128511)* Add `-skip-funcs` to BOLT options to fix computed goto errors* NEWS---------(cherry picked from commit24b147a)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
…to errors (pythongh-128511)* Add `-skip-funcs` to BOLT options to fix computed goto errorsCo-authored-by: Gregory Szorc <gregory.szorc@gmail.com>* NEWS---------Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This patch was originally authored as part ofastral-sh/python-build-standalone#463
Makes use of the common options added in#128455
Closes#128472
Backport needed for#124948
--enabled-sharedon LLVM 19 with "unable to get new address" #128472