Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Docs: mark up json.dump() using parameter list#128482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJan 4, 2025•
edited by hugovk
Loading

@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news labelsJan 4, 2025
@erlend-aasland
Copy link
ContributorAuthor

What do you think, Hugo?

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, looks good. A few non-blocking wording suggestions.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@erlend-aaslanderlend-aasland added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 4, 2025
@erlend-aaslanderlend-aasland marked this pull request as ready for reviewJanuary 4, 2025 15:40
@erlend-aasland
Copy link
ContributorAuthor

Thanks Hugo; it definitely looks better with those suggestions.

hugovk reacted with rocket emoji

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)January 4, 2025 15:41
@erlend-aaslanderlend-aasland merged commita0088b4 intopython:mainJan 4, 2025
33 checks passed
@erlend-aaslanderlend-aasland deleted the docs/json-dump-param-list branchJanuary 4, 2025 15:44
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 4, 2025
(cherry picked from commita0088b4)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-128486 is a backport of this pull request to the3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 4, 2025
(cherry picked from commita0088b4)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 4, 2025
@bedevere-app
Copy link

GH-128487 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 4, 2025
erlend-aasland added a commit that referenced this pull requestJan 4, 2025
…28486)(cherry picked from commita0088b4)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit that referenced this pull requestJan 4, 2025
…28487)(cherry picked from commita0088b4)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJan 4, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 4, 2025
(cherry picked from commit87ee760)Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 4, 2025
(cherry picked from commit87ee760)Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull requestJan 4, 2025
(cherry picked from commit87ee760)Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull requestJan 4, 2025
(cherry picked from commit87ee760)Co-authored-by: Erlend E. Aasland <erlend@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 6, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip issueskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@erlend-aasland@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp