Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128437: AddBOLT_COMMON_FLAGS with-update-debug-sections#128455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 2 commits intopython:mainfromzanieb:zb/bolt-common
Jan 5, 2025

Conversation

zanieb
Copy link
Contributor

@zaniebzanieb commentedJan 3, 2025•
edited by bedevere-appbot
Loading

Adds a common flags variable that is used for both instrument and apply steps. Adds-update-debug-sections to the instrument step to resolve the BOLT warning.

This patch was originally authored by@indygreg as part ofastral-sh/python-build-standalone#463

I dropped some additions toBOLT_COMMON_FLAGS, but will add them in a subsequent pull request.

Closes#128437

b-long reacted with heart emoji
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
@zanieb
Copy link
ContributorAuthor

I don't believe this needs a news entry.

erlend-aasland reacted with thumbs up emoji

@zanieb
Copy link
ContributorAuthor

As mentioned, theBOLT_COMMON_FLAGS will be subsequently used to fix#128472, e.g.,zanieb@5448cd9

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

zanieb reacted with heart emoji
@corona10corona10 merged commitb60044b intopython:mainJan 5, 2025
43 checks passed
@zaniebzanieb added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 5, 2025
@miss-islington-app
Copy link

Thanks@zanieb for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@zanieb for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 5, 2025
pythongh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`(cherry picked from commitb60044b)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 5, 2025
pythongh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`(cherry picked from commitb60044b)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
@bedevere-app
Copy link

GH-128512 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 5, 2025
@bedevere-app
Copy link

GH-128513 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 5, 2025
corona10 pushed a commit that referenced this pull requestJan 5, 2025
…s` (gh-128455) (gh-128512)gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`(cherry picked from commitb60044b)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
corona10 pushed a commit that referenced this pull requestJan 5, 2025
…s` (gh-128455) (gh-128513)gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`(cherry picked from commitb60044b)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 6, 2025
pythongh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
pythongh-128455)Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@corona10corona10

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bolt instrumentation missing-update-debug-sections
3 participants
@zanieb@corona10@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp