NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-128427: Add`uuid.NIL` and`uuid.MAX`#128429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 7 commits intopython:mainfromngnpope:nil-max-uuid

Jan 27, 2025

Merged

gh-128427: Add`uuid.NIL` and`uuid.MAX`#128429

hugovk merged 7 commits intopython:mainfromngnpope:nil-max-uuid

Jan 27, 2025

Conversation

Copy link

Contributor

ngnpope commentedJan 2, 2025•
edited by github-actionsbot
Loading

Adds constants for Nil and Max UUID formats as per RFC 9562.

Issue:Support Nil and Max UUID formats from RFC 9562 #128427

📚 Documentation preview 📚:https://cpython-previews--128429.org.readthedocs.build/

Adduuid.NIL anduuid.MAX

50c6294

bedevere-appbot mentioned this pull request

Jan 2, 2025

Support Nil and Max UUID formats from RFC 9562#128427

Closed

bedevere-appbot added the awaiting review label

Jan 2, 2025

Wulian233 reviewed

Jan 2, 2025

View reviewed changes

Doc/whatsnew/3.14.rst OutdatedShow resolvedHide resolved

picnixz self-requested a review

January 2, 2025 23:11

picnixz reviewed

Jan 3, 2025

View reviewed changes

Doc/library/uuid.rst OutdatedShow resolvedHide resolved

Doc/whatsnew/3.14.rstShow resolvedHide resolved

Lib/test/test_uuid.py OutdatedShow resolvedHide resolved

Lib/uuid.pyShow resolvedHide resolved

Misc/NEWS.d/next/Library/2025-01-02-20-34-04.gh-issue-128427.onPoQZ.rst OutdatedShow resolvedHide resolved

Doc/library/uuid.rstShow resolvedHide resolved

Edits to documentation

fc14200

ngnpope force-pushed thenil-max-uuid branch from9437f4e tofc14200Compare

January 3, 2025 11:15

Copy link

Member

picnixz commentedJan 3, 2025•
edited
Loading

By the way, avoid force-pushing in the future as it makes reviews harder; we eventually squash commits and write our own commit message (force-pushing is accepted in some cases only but those are quite rare (like fixing up a really wrong commit that should not be seen at all, or changing the committer's email/name to due CLA reasons)).

Edits to tests

8b71df2

ngnpope commented

Jan 3, 2025

View reviewed changes

Lib/test/test_uuid.py OutdatedShow resolvedHide resolved

picnixz reviewed

Jan 5, 2025

View reviewed changes

Copy link

Member

picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I forgot about the version and variant fields which I don't know what to do with.

Lib/test/test_uuid.py OutdatedShow resolvedHide resolved

Lib/test/test_uuid.pyShow resolvedHide resolved

ngnpope added2 commits

January 6, 2025 13:38

More tweaks to test assertions

2fde894

Add comments to test assertions

ecf263a

This comment was marked as resolved.

Empty commit to retrigger CI

cba80bc

picnixz approved these changes

Jan 6, 2025

View reviewed changes

Copy link

Member

picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just two nits and LGTM once a core dev allows it.

Lib/test/test_uuid.py OutdatedShow resolvedHide resolved

bedevere-appbot added awaiting core review and removed awaiting review labels

Jan 6, 2025

Remove extra links

bf61ffe

picnixz added the type-featureA feature request or enhancement label

Jan 13, 2025

picnixz self-requested a review

January 13, 2025 10:07

picnixz approved these changes

Jan 13, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Jan 13, 2025

hugovk approved these changes

Jan 13, 2025

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, just a couple of docs suggestions.

Doc/library/uuid.rst

		..data::NIL

		A special form of UUID that is specified to have all 128 bits set to zero
		according to:rfc:`RFC 9562, §5.9 <9562#section-5.9>`.

Copy link

Member

hugovkJan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Linking directly to the section is helpful, perhaps we only need to mention the RFC number here? If so, we could update the same thing foruuid8 above.

Suggested change