Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124363: Treat debug expressions in f-string as raw strings#128399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 5 commits intopython:mainfrompablogsal:gh-124363
Jan 22, 2025

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commentedJan 1, 2025•
edited by bedevere-appbot
Loading

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Parser/action_helpers.c: Language not supported
  • Parser/lexer/lexer.c: Language not supported

@pablogsal
Copy link
MemberAuthor

@lysnikolaou gentle ping.

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the ping@pablogsal! LGTM! Left a couple of comments to improve comments around the code.

@pablogsalpablogsal added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 22, 2025
@pablogsalpablogsalenabled auto-merge (squash)January 22, 2025 16:00
@pablogsalpablogsal merged commit60a3a0d intopython:mainJan 22, 2025
45 checks passed
@pablogsalpablogsal deleted the gh-124363 branchJanuary 22, 2025 16:24
@miss-islington-app
Copy link

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 22, 2025
…ythonGH-128399)(cherry picked from commit60a3a0d)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry,@pablogsal, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 60a3a0dd6fe140fdc87f6e769ee5bb17d92efe4e 3.12

@bedevere-app
Copy link

GH-129187 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 22, 2025
pablogsal added a commit that referenced this pull requestJan 22, 2025
…H-128399) (#129187)gh-124363: Treat debug expressions in f-string as raw strings (GH-128399)(cherry picked from commit60a3a0d)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull requestJan 22, 2025
…rings (pythonGH-128399)(cherry picked from commit60a3a0d)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@bedevere-app
Copy link

GH-129190 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 22, 2025
pablogsal added a commit that referenced this pull requestJan 22, 2025
…H-128399) (#129190)(cherry picked from commit60a3a0d)Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@eendebakpt
Copy link
Contributor

@pablogsal This PR gives a warning in the test output:

c:\projects\misc\cpython\Lib\test\test_fstring.py:1654: SyntaxWarning: "\N" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\\N"? A raw string is also an option.  self.assertEqual(f'{b"\N{OX}"=}', 'b"\\N{OX}"=b\'\\\\N{OX}\'')

Maybe the invalid escape sequence is intentional in the test, but it would be nice if the warning is suppressed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lysnikolaoulysnikolaoulysnikolaou left review comments

Copilot code reviewCopilotCopilot left review comments

Assignees

@pablogsalpablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@eendebakpt@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp