Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128340: make asyncio.events.Handle.cancel() atomic#128347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Lib/asyncio/events.py Outdated
| @property | ||
| def_cancelled(self): | ||
| returnself.cancelled() | ||
| @property | ||
| def_callback(self): | ||
| callback_args=self._callback_args | ||
| ifcallback_argsis_HANDLE_CANCELLED: | ||
| returnNone | ||
| returncallback_args[0] | ||
| @property | ||
| def_args(self): | ||
| callback_args=self._callback_args | ||
| ifcallback_argsis_HANDLE_CANCELLED: | ||
| returnNone | ||
| returncallback_args[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the tests access private attributes - I'd rather update those tests. These properties were just to get a PR up and passing CI quickly.
Misc/NEWS.d/next/Library/2024-12-30-11-38-12.gh-issue-128340.uyqrdQ.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| foriinrange(ntodo): | ||
| handle=self._ready.popleft() | ||
| ifhandle._cancelled: | ||
| ifhandle.cancelled(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This check is redundant because _run checks now
Uh oh!
There was an error while loading.Please reload this page.