Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128330: Terminal control characters should be restored on repl exit#128331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 4 commits intopython:mainfromomniosorg:fancy_termios
Jan 23, 2025

Conversation

@citrus-it
Copy link
Contributor

@citrus-itcitrus-it commentedDec 29, 2024•
edited by bedevere-appbot
Loading

@ghost
Copy link

ghost commentedDec 29, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@ZeroIntensityZeroIntensity added needs backport to 3.13bugs and security fixes topic-replRelated to the interactive shell labelsJan 12, 2025
@pablogsalpablogsal merged commit0b15d9c intopython:mainJan 23, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks@citrus-it for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 23, 2025
…pl exit (pythonGH-128331)(cherry picked from commit0b15d9c)Co-authored-by: Andy Fiddaman <andy@omnios.org>
@bedevere-app
Copy link

GH-129233 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 23, 2025
pablogsal pushed a commit that referenced this pull requestJan 23, 2025
…epl exit (GH-128331) (#129233)gh-128330: Terminal control characters should be restored on repl exit (GH-128331)(cherry picked from commit0b15d9c)Co-authored-by: Andy Fiddaman <andy@omnios.org>
Tripathi-Manjul pushed a commit to Tripathi-Manjul/cpython that referenced this pull requestJan 23, 2025
@ZeroIntensity
Copy link
Member

This was merged without a test. Is it worth adding one in a follow-up?

@pablogsal
Copy link
Member

There is not an easy way to test this that I can think of (just checking that the list is not modified doesn't actually test the fix) but if you can think of one I am happy to review the PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@pablogsalpablogsalpablogsal approved these changes

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

topic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@citrus-it@ZeroIntensity@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp