Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128321: SetLIBS instead ofLDFLAGS during sqlite3 library build checks#128322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 3 commits intopython:mainfromzanieb:zb/sqlite3-libs
Dec 30, 2024

Conversation

zanieb
Copy link
Contributor

@zaniebzanieb commentedDec 29, 2024•
edited
Loading

Closes#128321

See the issue for context.

There are a few alternative approaches we could take, such as:

  • Always including-lm during checks (which would over-link)
  • UsingPKG_CHECK_MODULES_STATIC instead ofPKG_CHECK_MODULES when shared libraries are disabled

I'm not really sure of the trade-offs. This seems like the simplest approach to unblock users who can setPKG_CONFIG to include the--static flag as mentioned inhttps://bugs.freedesktop.org/show_bug.cgi?id=19541#c7

@zaniebzanieb changed the titlegh-128321: SetLIBS during sqlite3 library build checksgh-128321: SetLIBS instead ofLDFLAGS during sqlite3 library build checksDec 30, 2024
@zaniebzanieb marked this pull request as ready for reviewDecember 30, 2024 05:24
@erlend-aaslanderlend-aasland merged commit81376fe intopython:mainDec 30, 2024
47 checks passed
@zanieb
Copy link
ContributorAuthor

Thanks for the review!

erlend-aasland reacted with heart emoji

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 30, 2024
…quirements (pythonGH-128322)(cherry picked from commit81376fe)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 30, 2024
…quirements (pythonGH-128322)(cherry picked from commit81376fe)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

GH-128355 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 30, 2024
@bedevere-app
Copy link

GH-128356 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 30, 2024
erlend-aasland added a commit that referenced this pull requestDec 30, 2024
…equirements (GH-128322) (#128355)(cherry picked from commit81376fe)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull requestDec 30, 2024
…equirements (GH-128322) (#128356)(cherry picked from commit81376fe)Co-authored-by: Zanie Blue <contact@zanie.dev>Co-authored-by: Erlend E. Aasland <erlend@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…quirements (python#128322)Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statically linkedsqlite3 fails checks due to missing-lm
2 participants
@zanieb@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp