Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-84559: improve What's New entry formultiprocessing start method changes#128173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedDec 22, 2024
edited by github-actionsbot
Loading

This is a proposal for an improved changelog. I am tempted to add it at the very top of the file in the "Summary -- release highlights" but I don't know if@hugovk is ok or not with it.


📚 Documentation preview 📚:https://cpython-previews--128173.org.readthedocs.build/

@picnixzpicnixz marked this pull request as draftDecember 22, 2024 11:50
@picnixzpicnixz marked this pull request as ready for reviewDecember 22, 2024 11:54
@hugovk
Copy link
Member

I am tempted to add it at the very top of the file in the "Summary -- release highlights" but I don't know if@hugovk is ok or not with it.

Yeah, this sounds like a big change we want people to know about, let's add a summary up there and link down to multiprocessing part.

I expect we'll expand the summary closer to the release, compare 3.13:

https://docs.python.org/3/whatsnew/3.13.html#summary-release-highlights

cc@AA-Turner

@jakirkham
Copy link

Just a note, on macOS the default is spawn (as it has been for a while). However the docs also note that POSIX uses forkserver by default. Though macOS also is a POSIX platform. Should this be disambiguated somehow?

@picnixz
Copy link
MemberAuthor

Though macOS also is a POSIX platform. Should this be disambiguated somehow

Ah yes, sorry. it should have been "On POSIX platforms, except macOS, [...]" or "On platforms other than macOS and Windows". Which one would be the clearer?

@gpsheadgpshead self-assigned thisDec 24, 2024
Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm glad we have a full section in the multiprocessing docs to link to (hooray past us!). But to help people from a What's New standpoint given the issues people are raising about this being confusing, I think we should pick a couple different short example error messages users might see coming out of an application that needs modification to work with the new start method when usingmultiprocessing orconcurrent.futures.

@picnixz
Copy link
MemberAuthor

I think we should pick a couple different short example error messages users might see coming out of an application that needs modification to work with the new start method when using multiprocessing or concurrent.futures.

What about improving the section inmultiprocessing about the differences between fork and spawn/forkserver by adding some "common issues" examples (and we can add a link to that section in the What's New entries) and/or possible examples of how to upgrade from 'fork' to 'spawn/forkserver'?

@gpshead
Copy link
Member

I think we should pick a couple different short example error messages users might see coming out of an application that needs modification to work with the new start method when using multiprocessing or concurrent.futures.

What about improving the section inmultiprocessing about the differences between fork and spawn/forkserver by adding some "common issues" examples (and we can add a link to that section in the What's New entries) and/or possible examples of how to upgrade from 'fork' to 'spawn/forkserver'?

Even just a sentence in What's New saying something along the lines of "if you are seeing name errors of pickling errors coming out of multiprocessing or concurrent.futures when you upgrade to 3.14, read ...link-to-section..." would help people understand. Expanding further upon that kind of thing in the multiprocessing docs as common issues would be good.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@picnixz
Copy link
MemberAuthor

Even just a sentence in What's New saying something along the lines of "if you are seeing name errors of pickling errors coming out of multiprocessing or concurrent.futures when you upgrade to 3.14, read ...link-to-section..."

I'll have a look at what to link tomorrow and if I have the motivation, I'll do something for the mp docs.

@ngoldbaum
Copy link
Contributor

Small ping that I ended up here after a discussion about this behavior and getting this docs improvement merged would help a lot. No rush of course but just don’t want this forgotten.

dmoerner reacted with thumbs up emoji

@picnixz
Copy link
MemberAuthor

Oh I forgot... I will try to make it by the end of the weekend. Let's make it as the next task. Thanks for the ping !

@picnixzpicnixz merged commitb8c313a intopython:mainFeb 23, 2025
28 checks passed
@picnixzpicnixz deleted the doc/multiprocessing/clarifications-84559 branchFebruary 23, 2025 09:35
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…method changes (python#128173)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@gpsheadgpsheadgpshead approved these changes

Assignees

@gpsheadgpshead

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@picnixz@hugovk@jakirkham@gpshead@ngoldbaum@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp