Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128152: Update Argument Clinic to support empty lines#128158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure it's the proper approach, although it may work. Empty lines could be incorrect directives depending on the DSL. In addition, please add tests forpython input directives and for pure clinic directives to see if something changed.
Closing in favour of#128464. Thanks for the PR, though! |
Uh oh!
There was an error while loading.Please reload this page.
This will skip the logic that follows after for empty lines so there should be no error. Assert is now no longer needed.
I don't this a NEWS worthy PR? If it is I can add an entry but I think a Skip NEWS label is just fine.
[python input]blocks do not support empty lines in comments #128152