NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047)#128114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hauntsaninja merged 1 commit intopython:3.13frommiss-islington:backport-45e6dd6-3.13

Dec 20, 2024

Merged

[3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047)#128114

hauntsaninja merged 1 commit intopython:3.13frommiss-islington:backport-45e6dd6-3.13

Dec 20, 2024

Conversation

Copy link

Contributor

miss-islington commentedDec 20, 2024•
edited by bedevere-appbot
Loading

I missed the extraPyModule_Check inGH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed thePyModuleCheck introduced inGH-112661.
(cherry picked from commit45e6dd6)

Co-authored-by: Shantanu12621235+hauntsaninja@users.noreply.github.com

Issue:Regression in 3.13.1 for imports of nonexistant names from CFFI modules #128030

pythongh-128030: Avoid error from PyModule_GetFilenameObject for non-…

76b88e6

…module (pythonGH-128047)I missed the extra `PyModule_Check` inpythonGH-127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpythonGH-112661.(cherry picked from commit45e6dd6)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>