Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127638: Prevent copying extended attributes of script files when creating venv#128105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
wimglenn wants to merge6 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+4 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Misc/NEWS.d/next/Library/2024-12-19-16-17-56.gh-issue-127638.Km-VEi.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…m-VEi.rstCo-authored-by: Peter Bierma <zintensitydev@gmail.com>
Why Linux can't copy files properly is out of my depth 😆 If this fixes it, sure. @vsajip likes to look in on venv changes. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
awaiting reviewneeds backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes topic-venvRelated to the venv module
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Prevent the regression in Python 3.13 on Linux when creating a venv from interpreter hosted on large xattr filesystem.
There are a few other
copy2usages invenv/__init__.pybut they are all gated by conditions onos.name == 'nt'so don't affect Linux.Instead of handling the possible error from the copy (which looks like:
shutil.copy2 -> copystat -> _copyattr -> os.setxattr -> OSError: [Errno 28] No space left on device) I've opted to just remove that conditional. I don't think we want to have attrs or not based on whethernew_data == data, rather we want them always there or not regardless of file content.