Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-124111: Fix TCL 9 threaded detection#128103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
ghost commentedDec 19, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs a blurb, otherwise LGTM.
Uh oh!
There was an error while loading.Please reload this page.
Original threaded detection doesn't work with TCL 9. Instead setting to always enable threaded based on release note for TCL 9+
https://sourceforge.net/projects/tcl/files/Tcl/9.0.0/tcl-release-notes-9.0.0.md/download:
Notes
gh-124111as it was for general TCL 9 support (similarly piggy-backing off NEWS blurb as wasn't in stable release). Could create a separate issue/blurb if preferred.TCL_MAJOR_VERSIONas original logic was for looking for threaded in TCL. Could checkTK_MAJOR_VERSIONinstead as the major versions should be the same.