Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function#128079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function#128079
Changes from1 commit
Commits
Show all changes
7 commits Select commitHold shift + click to select a range
fb869d4 have checks for the return value of split be done outside of asserts
Nico-Posada7a482a4 added NEWS entry and fixed linter error
Nico-Posada723a6a6 Fix rst error
Nico-Posadaa360e60 code review changes
Nico-Posada5444a91 Fix linter errors
Nico-Posada05d809b code review changes
Nico-Posadad13f32a Merge branch 'main' into fix-issue-128049
iritkatrielFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Fix linter errors
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit5444a91135aee49f55cc038e1a7129673fa5b442
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -951,7 +951,7 @@ def derive(self, excs): | ||
| self.assertExceptionIsLike(exc, FalsyEG("eg", [TypeError(1)])) | ||
| self.assertExceptionIsLike(tes, FalsyEG("eg", [TypeError(1)])) | ||
| self.assertExceptionIsLike(ves, FalsyEG("eg", [ValueError(2)])) | ||
| def test_bad_exception_group_subclass_split_func(self): | ||
Nico-Posada marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| # See https://github.com/python/cpython/issues/128049 | ||
| # tuples that return less than 2 values should | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.