Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-128062: Fix the font size and shortcut display of the turtledemo menu#128063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…s too large and the shortcut key is displayed inaccurately
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Could we be more clear (in both the PR title and the blurb entry) about what this is changing? ("improve" is too vague of a term)
Misc/NEWS.d/next/Library/2024-12-18-10-18-55.gh-issue-128062.E9oU7-.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…9oU7-.rstCo-authored-by: Peter Bierma <zintensitydev@gmail.com>
turtledemoturtledemo's menu bar to its default value and display the shortcut keys in the correct positionturtledemo's menu bar to its default value and display the shortcut keys in the correct positionterryjreedy commentedDec 18, 2024
I fixed title and commit message. The macOS failure seems to be a known unrelated issue,#128069. Merging seems to be blocked until this is fixed. |
terryjreedy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
On my MacBook Air, with a small screen, fontsize 12 is too small as the default, used for the top bar, appears to be 14. Command+- and Command+= are the keys that work in the text widget. Agree with leaving size alone and using the standard accelerator option.
e163e8d intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@Xiaokang2022 for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…demo menu (pythonGH-128063)Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.---------(cherry picked from commite163e8d)Co-authored-by: Zhikang Yan <2951256653@qq.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sorry,@Xiaokang2022 and@terryjreedy, I could not cleanly backport this to |
GH-128101 is a backport of this pull request to the3.13 branch. |
…edemo menu (GH-128063) (#128101)gh-128062: Fix the font size and shortcut display of the turtledemo menu (GH-128063)Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.---------(cherry picked from commite163e8d)Co-authored-by: Zhikang Yan <2951256653@qq.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…demo menu (python#128063)Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.---------Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…demo menu (python#128063)Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.---------Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Uh oh!
There was an error while loading.Please reload this page.
Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.