Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128030: Avoid error from PyModule_GetFilenameObject for non-module#128047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 3 commits intopython:mainfromhauntsaninja:gh-128030
Dec 20, 2024

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninjahauntsaninja commentedDec 17, 2024•
edited
Loading

I missed the extraPyModule_Check in#127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed thePyModuleCheck introduced in#112661 (seehere).

…moduleI missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
@hauntsaninjahauntsaninja added the needs backport to 3.13bugs and security fixes labelDec 18, 2024
@hauntsaninjahauntsaninja merged commit45e6dd6 intopython:mainDec 20, 2024
47 checks passed
@miss-islington-app
Copy link

Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 20, 2024
…module (pythonGH-128047)I missed the extra `PyModule_Check` inpythonGH-127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpythonGH-112661.(cherry picked from commit45e6dd6)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-app
Copy link

GH-128114 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 20, 2024
@hauntsaninjahauntsaninja deleted the gh-128030 branchDecember 20, 2024 08:23
hauntsaninja added a commit that referenced this pull requestDec 20, 2024
…-module (GH-128047) (#128114)gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047)I missed the extra `PyModule_Check` inGH-127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inGH-112661.(cherry picked from commit45e6dd6)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 LTO + PGO 3.x has failed when building commit45e6dd6.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/78/builds/8070) and take a look at the build logs.
  4. Check if the failure is related to this commit (45e6dd6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/78/builds/8070

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line1054, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line996, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line30, intask    interp= interpreters.create()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestDec 23, 2024
…module (python#128047)I missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…module (python#128047)I missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hauntsaninja@bedevere-bot@brettcannon
[8]ページ先頭
©2009-2025 Movatter.jp