Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning#128007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettcannon merged 15 commits intopython:mainfromtomasr8:importlib-deprecations
Jan 15, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedDec 16, 2024•
edited by bedevere-appbot
Loading

Largely based on work done by@rashansmith, this adds deprecation warnings for the following importlib classes, methods and attributes (using the docs as the source of truth):

The deprecation messages are based on the docs. Warnings forDEBUG_BYTECODE_SUFFIXES andOPTIMIZED_BYTECODE_SUFFIXES are implemented using a module__getattr__.

Feedback welcome!

tomasr8and others added7 commitsDecember 16, 2024 21:40
Co-authored-by: rashansmith <smith.rashan@gmail.com>
Co-authored-by: rashansmith <smith.rashan@gmail.com>
…CODE_SUFFIXES.Co-authored-by: rashansmith <smith.rashan@gmail.com>
Co-authored-by: rashansmith <smith.rashan@gmail.com>
@tomasr8
Copy link
MemberAuthor

cc@StanFromIreland

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two little things I noticed. I did not have time to go through the rest but it looks good in general.

tomasr8 reacted with thumbs up emoji
tomasr8and others added2 commitsDecember 16, 2024 22:55
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon
Copy link
Member

Sorry about the review delay!

tomasr8 reacted with heart emoji

@tomasr8
Copy link
MemberAuthor

Sorry about the review delay!

No worries, and thanks for the review! I think I addressed your comments if you feel like having another look :)

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@brettcannonbrettcannon merged commitbd3baa8 intopython:mainJan 15, 2025
38 checks passed
@brettcannon
Copy link
Member

Thanks,@tomasr8 for bearing with me and my delayed reviews! 😅

tomasr8 reacted with heart emoji

@tomasr8tomasr8 deleted the importlib-deprecations branchJanuary 15, 2025 06:59
@tomasr8
Copy link
MemberAuthor

No worries :) Thanks for the review!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@graingertgraingertgraingert left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@tomasr8@brettcannon@graingert@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp