Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127989: C API: Refer to attached thread states instead of the GIL#127990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
ad7ee2d
bea045a
e286ba5
6006b22
8dc3928
f46ca3d
555a03c
ddb98cd
5d423f8
d2d2f67
aa9c4c6
c05be67
3a69922
3336ad7
3991681
6d397eb
3b7b3ff
5358d14
093ba05
11582fa
3d55d2d
2785c1d
6d80b02
94e046b
713beb2
2140bde
f608211
d619387
e7828ed
6b33565
6230177
f74832a
7161fc0
d58b74f
a761c4a
de122f5
0b0176b
c15f5c4
0130b20
a1e47b7
0173c46
166d970
adae494
a70ab11
8584c86
48b145a
8ce3d7d
e5f1d18
905ca5b
f2826c4
5c44391
7d5877f
283fc92
a7488ab
4c532b6
352acc5
ed550bc
d7cf403
f61a6da
36af941
0b23daa
163b0b8
3b2bed8
80ae46b
3dee63f
9ed3a0b
b3cbbf8
1c37d59
32a4937
2fba67c
a0dc12c
94619f6
e6f1f28
828d24b
ace174f
788d735
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. A few points to consider, which are reflected in my other comments:
The only tricky part is that we already talk about "contexts" relative to asyncio. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'll commit the suggestions tomorrow when I'm available to do a full find-and-replace so I don't blow up CI in the meantime. For the per-thread thread state pointer (what a mouthful!), I'm happy with something like "runtime context," because there was no prior term for it, but I think we do want to keep the term "thread state." Thread states are documented, and users like to read the source code to understand some C functions--seeing
Hmm, we do have "borrowed reference" and "strong reference" in there; where else should "thread state" point to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
I like "thread state" :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. +1 for sticking with thread state. Between contextvars and context managers, and just the general idea of "context of execution", "context" is seriously overloaded already. "thread state" isn't completely unambiguous (it could theoretically take on the holistic meaning of "all state associated with the current thread, including the execution stack and all thread local variables"), but the context(!) of use should help avoid that misinterpretation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. "Runtime context" in particular is problematic, since the execution model is set up with the hierarchy of:
|