NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-126085: Add`tp_iter` to TypeAliasType to allow star unpacking#127981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 13 commits intopython:mainfromtomasr8:type-alias-iter

Mar 4, 2025

Merged

gh-126085: Add`tp_iter` to TypeAliasType to allow star unpacking#127981

JelleZijlstra merged 13 commits intopython:mainfromtomasr8:type-alias-iter

Mar 4, 2025

Conversation

Copy link

Member

tomasr8 commentedDec 16, 2024•
edited by ZeroIntensity
Loading

As@JelleZijlstra suggested, this simply adds atp_iter slot that returnsUnpack[self], same as we do for TypeVarTuple.

Feedback welcome!

Issue:Unpacking TypeAliasType to tuple of types using * errors at runtime, Unpack doesn't #126085

📚 Documentation preview 📚:https://cpython-previews--127981.org.readthedocs.build/en/127981/library/typing.html#typing.TypeAliasType

tomasr8 added2 commits

December 15, 2024 16:53

Add tp_iter for TypeAliasType

e2e6bdb

Add news entry

982737c

tomasr8 requested a review fromEclips4

December 16, 2024 11:07

tomasr8 requested review fromJelleZijlstra andmarkshannon ascode owners

December 16, 2024 11:07

bedevere-appbot mentioned this pull request

Dec 16, 2024

Unpacking TypeAliasType to tuple of types using * errors at runtime, Unpack doesn't#126085

Closed

bedevere-appbot added the awaiting review label

Dec 16, 2024

picnixz reviewed

Dec 16, 2024

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2024-12-15-16-56-26.gh-issue-126085.BvyEXk.rst OutdatedShow resolvedHide resolved

ZeroIntensity reviewed

Dec 16, 2024

View reviewed changes

Objects/typevarobject.cShow resolvedHide resolved

tomasr8 added3 commits

December 16, 2024 21:22

Keep function names consistent

e8674d7

Add whatsnew entry

4ffeefc

Update docs

6674aa1

tomasr8 requested a review fromAlexWaygood as acode owner

December 16, 2024 20:22

Fix typo

d42645f

picnixz reviewed

Dec 16, 2024

View reviewed changes

Doc/whatsnew/3.14.rstShow resolvedHide resolved

tomasr8and others added2 commits

December 16, 2024 21:29

Update Doc/whatsnew/3.14.rst

03744a6

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Fix sphinx errors

f605921

tomasr8 requested review fromZeroIntensity andpicnixz

December 16, 2024 21:34

ZeroIntensity reviewed

Dec 16, 2024

View reviewed changes

Copy link

Member

ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly LGTM, with two comments.

Misc/NEWS.d/next/Core_and_Builtins/2024-12-15-16-56-26.gh-issue-126085.BvyEXk.rst OutdatedShow resolvedHide resolved

Lib/test/test_type_aliases.pyShow resolvedHide resolved

Update news entry

186dc48

picnixz approved these changes

Dec 16, 2024

View reviewed changes

bedevere-appbot added awaiting core review and removed awaiting review labels

Dec 16, 2024

ZeroIntensity approved these changes

Dec 17, 2024

View reviewed changes

Copy link

Member

ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Eclips4 approved these changes

Dec 17, 2024

View reviewed changes

Copy link

Member

Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

bedevere-appbot added awaiting merge and removed awaiting core review labels

Dec 17, 2024

JelleZijlstra reviewed

Dec 18, 2024

View reviewed changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, some nits.

Objects/typevarobject.c Outdated


		#include"clinic/typevarobject.c.h"

		#definetypevartuple_iter unpack_iter

Copy link

Member

JelleZijlstraDec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think we need these defines, just useunpack_iter directly.

Copy link

MemberAuthor

tomasr8Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was a suggestion from@ZeroIntensity to keep the naming more consistent. I can remove them though

Copy link

Member

JelleZijlstraMar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you remove them?

Copy link

Member

ZeroIntensityMar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was complaining originally about the naming inconsistency, but in hindsight, it's probably better than the extra#define.

Copy link

MemberAuthor

tomasr8Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll remove them (and fix the conflict) later today :)

Copy link

MemberAuthor

tomasr8Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed!

Objects/typevarobject.c OutdatedShow resolvedHide resolved

Update comment in Objects/typevarobject.c

dcb1b7b

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

tomasr8 requested a review fromJelleZijlstra

January 30, 2025 10:20

tomasr8 added3 commits

February 2, 2025 12:37

Merge branch 'main' into type-alias-iter

3607006

Remove extra defines

3597b66

Merge remote-tracking branch 'upstream/main' into type-alias-iter

ab53431

JelleZijlstra approved these changes

Mar 4, 2025

View reviewed changes

JelleZijlstra merged commite091520 intopython:main

Mar 4, 2025

42 checks passed

bedevere-appbot removed the awaiting merge label

Mar 4, 2025

tomasr8 deleted the type-alias-iter branch

March 5, 2025 06:45

seehwan pushed a commit to seehwan/cpython that referenced this pull request

Apr 16, 2025

pythongh-126085: Addtp_iterto TypeAliasType to allow star unpacki…

18e0ccd

…ng (python#127981)

Labels

None yet

Movatterモバイル変換

Uh oh!

gh-126085: Addtp_iter to TypeAliasType to allow star unpacking#127981

gh-126085: Addtp_iter to TypeAliasType to allow star unpacking#127981

Uh oh!

Conversation

tomasr8 commentedDec 16, 2024• edited by ZeroIntensityLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Eclips4 left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstraDec 18, 2024

Choose a reason for hiding this comment

Uh oh!

tomasr8Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

JelleZijlstraMar 3, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensityMar 3, 2025

Choose a reason for hiding this comment

Uh oh!

tomasr8Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

tomasr8Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-126085: Add`tp_iter` to TypeAliasType to allow star unpacking#127981

gh-126085: Add`tp_iter` to TypeAliasType to allow star unpacking#127981

tomasr8 commentedDec 16, 2024•
edited by ZeroIntensity
Loading