Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-126985: Don't override venv detection with PYTHONHOME#127968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@FFY00
Copy link
Member

@FFY00FFY00 commentedDec 15, 2024
edited by bedevere-appbot
Loading

PYTHONHOME should only override the base prefix calculation, it should have no effect on detecting if we are running inside a virtual environment.

PYTHONHOME should only override the base prefix calculation, it shouldhave no effect on detecting if we are running inside a virtualenvironment.Signed-off-by: Filipe Laíns <lains@riseup.net
@FFY00
Copy link
MemberAuthor

FFY00 commentedDec 15, 2024
edited
Loading

Without the fixprefix andexec_prefix would be set toPYTHONHOME:

test test_getpath failed -- Traceback (most recent call last):  File "/home/anubis/git/cpython/Lib/test/test_getpath.py", line 865, in test_PYTHONHOME_in_venv    self.assertEqual(expected, actual)    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^AssertionError: {'exe[37 chars]': '/venv', 'exec_prefix': '/venv', 'base_pref[206 chars]ad']} != {'exe[37 chars]': '/pythonhome', 'exec_prefix': '/pythonhome'[218 chars]ad']}  {'base_exec_prefix': '/pythonhome',   'base_prefix': '/pythonhome',-  'exec_prefix': '/venv',?                   ^ --+  'exec_prefix': '/pythonhome',?                   ^^^^^^^^^   'executable': '/venv/bin/python',   'module_search_paths': ['/pythonhome/lib/python98.zip',                           '/pythonhome/lib/python9.8',                           '/pythonhome/lib/python9.8/lib-dynload'],   'module_search_paths_set': 1,-  'prefix': '/venv'}+  'prefix': '/pythonhome'}

@FFY00FFY00 changed the titleGH-126985: Don't override venv dectection whith PYTHONHOMEGH-126985: Don't override venv dectection with PYTHONHOMEDec 15, 2024
@FFY00FFY00 changed the titleGH-126985: Don't override venv dectection with PYTHONHOMEGH-126985: Don't override venv detection with PYTHONHOMEDec 15, 2024
@FFY00FFY00 merged commitb74c8f5 intopython:mainDec 15, 2024
40 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FFY00

[8]ページ先頭

©2009-2025 Movatter.jp