Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
GH-126985: Don't override venv detection with PYTHONHOME#127968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
FFY00 merged 1 commit intopython:mainfromFFY00:gh-126985-ignore-home-when-calculation-venv-prefixDec 15, 2024
Merged
GH-126985: Don't override venv detection with PYTHONHOME#127968
FFY00 merged 1 commit intopython:mainfromFFY00:gh-126985-ignore-home-when-calculation-venv-prefixDec 15, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
PYTHONHOME should only override the base prefix calculation, it shouldhave no effect on detecting if we are running inside a virtualenvironment.Signed-off-by: Filipe Laíns <lains@riseup.net
MemberAuthor
FFY00 commentedDec 15, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Without the fix |
b74c8f5 intopython:main 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PYTHONHOMEshould only override the base prefix calculation, it should have no effect on detecting if we are running inside a virtual environment.pyvenv.cfg-relocation part of the interpreter initialization instead of thesitemodule #126985