Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-128863: deprecate _PyLong_FromDigits() function#127939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-128863: deprecate _PyLong_FromDigits() function#127939
Uh oh!
There was an error while loading.Please reload this page.
Conversation
skirpichev commentedDec 14, 2024
Ok, this depend on#127925 |
vstinner commentedJan 23, 2025
You can use the macros in _decimal: See examples in Modules/_testcapimodule.c. |
vstinner commentedJan 23, 2025
_PyLong_Copy() emits a deprecation warning. You can rename _PyLong_FromDigits() to long_fromdigits() and use this one in _PyLong_Copy(). |
skirpichev commentedJan 23, 2025
This is a draft due to#127925.
That does make sense if no stdlib module will depend on _PyLong_FromDigits(). Unfortunately, there is no short cut for copy.copy() in C-API. |
vstinner commentedJan 23, 2025
I'm not sure that PRgh-127925 is ever going to be merged :-(
I didn't understand your comment. I'm only proposing a local "fix" for _PyLong_Copy() to avoid the deprecation warning. |
skirpichev commentedJan 24, 2025
Nevermind, I was thinking about
That seems fine. But maybe we should just inline code, it's not used anywhere else in the longobject.c. |
skirpichev commentedJan 24, 2025
Ok, I did this ready for review. Once#127925 will be merged - this should pass tests. After some thinking, the |
vstinner commentedJan 24, 2025
You should use _Py_COMP_DIAG_IGNORE_DEPR_DECLS in _decimal.c, as I wrote in my previous comment. |
skirpichev commentedJan 24, 2025
No, this rather fits for testing code. |
Uh oh!
There was an error while loading.Please reload this page.
233fd00 intopython:mainUh oh!
There was an error while loading.Please reload this page.
vstinner commentedJan 24, 2025
Merged, thanks. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--127939.org.readthedocs.build/