Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127146: Some expected failures in Emscripten time tests#127843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This xfails two tests in the test_time suite. It also adjusts test_osto reflect the fact that in Emscripten file modification times innanoseconds since the linux epoch get round tripped through a 53 bitinteger so we only get 5 subsecond digits of precision.
freakboy3742 approved these changesDec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 An annoying discrepancy on subsection accuracy, but this is a pragmatic workaround until such time as this can be fixed upstream.
41f29e5 intopython:main 46 checks passed
Uh oh!
There was an error while loading.Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…hon#127843)Disables two tests in the test_time suite, and adjusts test_os to reflect precision limits in Emscripten.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This xfails two tests in the test_time suite. It also adjusts test_os to reflect the fact that in Emscripten file modification times in nanoseconds since the linux epoch get round tripped through a 53 bit integer so we only get 5 subsecond digits of precision.