All commit authors signed the Contributor License Agreement.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Thanks@mbachry for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

GH-134474 is a backport of this pull request to the3.14 branch.

GH-134475 is a backport of this pull request to the3.13 branch.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 CentOS9 NoGIL 3.x (tier-1) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1609/builds/2712) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1609/builds/2712

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_qkt9f__m.sock>kTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python__7ampq2z.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian 3.x (tier-3) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/424/builds/10802) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/424/builds/10802

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_pbof1ewy.sock>kTraceback (most recent call last):  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_c4s0l6jd.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 macOS 3.x (tier-2) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/11042) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/11042

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_wz11kla7.sock>kTraceback (most recent call last):  File"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_i_w9uwih.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86 Debian Non-Debug with X 3.x (no tier) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1245/builds/5543) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1245/builds/5543

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ohnp943n.sock>�[32mok�[0mTraceback (most recent call last):  File"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_widcf142.sock>�[32mok�[0m

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 FreeBSD14 3.x (tier-3) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1232/builds/5887) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1232/builds/5887

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python__er5v_tk.sock>kTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ooydm3gw.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel NoGIL 3.x (tier-1) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1258/builds/5081) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1258/builds/5081

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=9, family=1, type=2, proto=0, laddr=./test_python_q4t3ldap.sock>kTraceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=8, family=1, type=2, proto=0, laddr=./test_python_059fgnzk.sock>k

hmm, probably need to revert this while figuring those out...

#134482

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 Raspbian 3.x (tier-3) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1678/builds/116) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1678/builds/116

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_xg5dcebk.sock>kTraceback (most recent call last):  File"/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_w7b6g3fn.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x (no tier) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/469/builds/11175) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/469/builds/11175

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ht3a1kva.sock>kTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_s5youw7c.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10726) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10726

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_qamhsx8n.sock>kTraceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_r4fctla0.sock>k

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 macOS 3.x (tier-1) has failed when building commit518c95b.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/366/builds/9576) and take a look at the build logs.
4. Check if the failure is related to this commit (518c95b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/366/builds/9576

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_fj5uabmh.sock>kTraceback (most recent call last):  File"/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/unittest/case.py", line615, in_callTestMethod    result= method()ResourceWarning:unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_xtxh8y64.sock>k

hmm, probably need to revert this while figuring those out...

Right, sorry about that. Forgot to wrap that socket in a context manager in a test case. It's a pity that localmake test and CI pass and this trivial error is revealed only after merging.make test TESTPYTHONOPTS=-Werror reproduces the issue locally, but I'm not able to run the entire test suite with warnings on, so it's not a viable permanent solution.

In any case, it's a simple fix, so I can open another pr.