Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: Use bash to properly expand variable#127822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromhugovk:ci-windows-ci-shell-bash
Dec 11, 2024

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commentedDec 11, 2024•
edited
Loading

Follow on from#127749.

Re:#127786 (comment).

Needs backporting to 3.13 but was already added to 3.12 in#127788.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

persist-credentials:false
-name:Build CPython installer
run:.\Tools\msi\build.bat --doc -"${ARCH}"
run:./Tools/msi/build.bat --doc -"${ARCH}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems that withshell: bash both/ and\\ work for paths, but not\.
I've seen (and used)\\ elsewhere, but since this is the only instance in this file and/ is more readable we don't need to worry about consistency here.

hugovk and AlexWaygood reacted with thumbs up emoji
Copy link
Member

@AlexWaygoodAlexWaygoodDec 11, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes,/ and\\ are both valid path separators on Windows, so using/ always works fine for paths on Windows. The difference between the platforms is that/ is not thedefault path separator on Windows.

ezio-melotti reacted with thumbs up emojihugovk reacted with eyes emoji
@hugovkhugovkenabled auto-merge (squash)December 11, 2024 12:48
@hugovkhugovk merged commitb2ad7e0 intopython:mainDec 11, 2024
52 checks passed
@hugovkhugovk deleted the ci-windows-ci-shell-bash branchDecember 11, 2024 12:57
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 11, 2024
(cherry picked from commitb2ad7e0)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-127824 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 11, 2024
AlexWaygood pushed a commit that referenced this pull requestDec 11, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees

No one assigned

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@ezio-melotti@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp