Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.13] Add zizmor to pre-commit and fix most findings (#127749)#127786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>(cherry picked from commitae31df3)
AlexWaygood commentedDec 10, 2024
Looks like you might need to add |
hugovk commentedDec 10, 2024
No, JIT/Windows is also failing in a clean 3.13 branch:https://github.com/hugovk/cpython/actions/runs/12255332851/job/34188652334 And the changes in cc@brandtbucher FYI |
AlexWaygood commentedDec 10, 2024
Ah, thanks, I should have looked more closely! |
AlexWaygood commentedDec 10, 2024
I think the Windows failures in#127788 might be related, however? The error message there is different |
990ea33 intopython:3.13Uh oh!
There was an error while loading.Please reload this page.
| persist-credentials:false | ||
| -name:Build CPython installer | ||
| run:.\Tools\msi\build.bat --doc -${{ inputs.arch }} | ||
| run:.\Tools\msi\build.bat --doc -"${ARCH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this probably should also have been
| run:.\Tools\msi\build.bat --doc -"${ARCH}" | |
| run:.\Tools\msi\build.bat --doc -"${ARCH}" | |
| shell:bash |
maybe this job doesn't run on PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmmm... are we absolutely confident that the environment variable was properly expanded as part of the command that successfully ran in that workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's double check. Just heading out to Helsinki Python, I can check tomorrow if no-one beats me to it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Co-authored-by: Alex WaygoodAlex.Waygood@Gmail.com
(cherry picked from commitae31df3)