Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-127734: improve signature of`urllib.request.HTTPPasswordMgrWithPriorAuth.init`#127735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

orsenthil merged 1 commit intopython:mainfromtungol:urllib

Dec 8, 2024

Merged

gh-127734: improve signature of`urllib.request.HTTPPasswordMgrWithPriorAuth.init`#127735

orsenthil merged 1 commit intopython:mainfromtungol:urllib

Dec 8, 2024

Conversation

@tungol

Copy link

Contributor

tungol commentedDec 8, 2024•
edited
Loading

A small MR to improve signature introspection ofurllib.request.HTTPPasswordMgrWithPriorAuth.__init__. The parent class takes no arguments, so the pass-through serves no purpose. Currently, typeshed needs to haveurllib.request.HTTPPasswordMgrWithPriorAuth.__init__ on its allowlist for stubtest errors as a result of the poor introspection.

Issue:Improving signature ofurllib.request.HTTPPasswordMgrWithPriorAuth.__init__ #127734

@tungol

improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__in…

8028a0e

…it__

@bedevere-app

bedevere-appbot mentioned this pull request

Improving signature ofurllib.request.HTTPPasswordMgrWithPriorAuth.__init__#127734

Closed

@bedevere-app

bedevere-appbot added the awaiting review label

orsenthil

orsenthil approved these changes

View reviewed changes

Copy link

Member

orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@bedevere-app

bedevere-appbot added awaiting merge and removed awaiting review labels

@orsenthil

orsenthil added skip news 3.12only security fixes labels

@orsenthil

orsenthil merged commita03efb5 intopython:main

46 checks passed

@bedevere-app

bedevere-appbot removed the awaiting merge label

@orsenthil

orsenthil added needs backport to 3.12

only security fixes

needs backport to 3.13bugs and security fixes labels

@miss-islington-app

Copy link

miss-islington-appbot commentedDec 8, 2024

Thanks@tungol for the PR, and@orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link

miss-islington-appbot commentedDec 8, 2024

Thanks@tungol for the PR, and@orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@orsenthil

orsenthil removed the 3.12only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

@tungol

@miss-islington

pythongh-127734: improve signature of `urllib.request.HTTPPasswordMgr…

a9d4dbe

…WithPriorAuth.__init__` (pythonGH-127735)improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__(cherry picked from commita03efb5)Co-authored-by: Stephen Morton <git@tungol.org>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

@tungol

@miss-islington

pythongh-127734: improve signature of `urllib.request.HTTPPasswordMgr…

9f90974

…WithPriorAuth.__init__` (pythonGH-127735)improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__(cherry picked from commita03efb5)Co-authored-by: Stephen Morton <git@tungol.org>

@bedevere-app

Copy link

bedevere-appbot commentedDec 8, 2024

GH-127744 is a backport of this pull request to the3.13 branch.

@bedevere-app

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

@bedevere-app

Copy link

bedevere-appbot commentedDec 8, 2024

GH-127745 is a backport of this pull request to the3.12 branch.

@bedevere-app

bedevere-appbot removed the needs backport to 3.12only security fixes label

orsenthil pushed a commit that referenced this pull request

@miss-islington

@tungol

[3.13]gh-127734: improve signature of `urllib.request.HTTPPasswordMg…

b56100c

…rWithPriorAuth.__init__` (GH-127735) (#127744)gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735)improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__(cherry picked from commita03efb5)Co-authored-by: Stephen Morton <git@tungol.org>

orsenthil pushed a commit that referenced this pull request

@miss-islington

@tungol

[3.12]gh-127734: improve signature of `urllib.request.HTTPPasswordMg…

5f5624d

…rWithPriorAuth.__init__` (GH-127735) (#127745)gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735)improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__(cherry picked from commita03efb5)Co-authored-by: Stephen Morton <git@tungol.org>

@tungol

tungol deleted the urllib branch

December 8, 2024 20:18

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

@tungol

@srinivasreddy

pythongh-127734: improve signature of `urllib.request.HTTPPasswordMgr…

15a10da

…WithPriorAuth.__init__` (python#127735)improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

2 participants

@tungol

@orsenthil

[8]ページ先頭

©2009-2025 Movatter.jp