Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-125413: Addpathlib.Path.info attribute#127730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
When a path object is generated by `PathBase.iterdir()`, then its `_info`attribute now stores a `os.DirEntry`-like object that can be used to querythe file type. This removes any need for a `_scandir()` method.Currently the `_info` attribute is private and only guaranteed to bepopulated in paths from `iterdir()`. Later on, I'm hoping to rename it to`info` and ensure that it's populated for all kinds of paths (this probablyinvolves adding a `pathlib.FileInfo` class.) In the pathlib ABCs, `info`will replace `stat()` as the lowest-level abstract file status queryingmechanism.
Steve - hopefully this helps address the issues you raised in#127377, but perhaps I'm only moving the problem around here. |
I think this is just moving stuff around. It might end up being the right places, but let's see the Discourse discussion play out a bit first. |
_scandir() with_info_scandir() with_status_scandir() with_statuspathlib.Path.status attributeI've revised the PR to be a more complete implementation of what I described on the forum, mostly as a demonstration/proof-of-concept at this stage. |
Right, I think this is ready for review. Alyssa, sorry if this seems like deja-vu! |
pathlib.Path.status attributepathlib.Path.info attributeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks great, thank you!
I do have a nitpick:
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Thank you Petr :) I'll wait another month until I merge, in case Alyssa or Steve have feedback |
I'll merge this on Friday if there's no further feedback. Cheers |
718ab66 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add
pathlib.Path.infoattribute, which stores an object implementing thepathlib.types.PathInfoprotocol (also new). The object supports querying the file type and internally cachingos.stat()results. Path objects generated byPath.iterdir()are initialised with status information fromos.DirEntryobjects, which is gleaned from scanning the parent directory.The
PathInfoprotocol has four methods:exists(),is_dir(),is_file()andis_symlink().os.DirEntryobjects from pathlib #125413