Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127718: Add colour totest.regrtest output#127719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 4 commits intopython:mainfromhugovk:3.14-regrtest-colour
Dec 10, 2024

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedDec 7, 2024
edited
Loading

Eclips4, nineteendo, and sobolevn reacted with thumbs up emoji
error: Name state is not defined [name-defined]
error: Cannot find implementation or library stub for module named _colorize  [import-not-found]
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we need to test this? We havehttps://github.com/python/cpython/blob/main/Lib/test/test_regrtest.py file where this might fit.

@hugovk
Copy link
MemberAuthor

I've added some tests.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks!

hugovk reacted with rocket emoji
Copy link
Member

@Eclips4Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.
Thank you Hugo for coloring unittest and our test suite!

hugovk reacted with rocket emoji
@hugovkhugovk merged commit212448b intopython:mainDec 10, 2024
50 checks passed
@hugovkhugovk deleted the 3.14-regrtest-colour branchDecember 10, 2024 07:44
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn left review comments

@Eclips4Eclips4Eclips4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@sobolevn@Eclips4

[8]ページ先頭

©2009-2025 Movatter.jp