Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: amend references starting with!~ in gh-127054#127684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromkoyuki7w:doc-fix-2
Dec 6, 2024

Conversation

koyuki7w
Copy link
Contributor

@koyuki7wkoyuki7w commentedDec 6, 2024•
edited by bedevere-appbot
Loading

The references starting with!~ are not rendered correctly (as pointed out in#127054 (comment))

📚 Documentation preview 📚:https://cpython-previews--127684.org.readthedocs.build/

The references starting with `!~` are not rendered correctly(as pointed out inpython#127054 (comment))
@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news awaiting review labelsDec 6, 2024
@skirpichev
Copy link
Member

I would rather suggest to revert the datastructures.rst change (and its backports!). Note that before - short method names were used.

CC@vstinner

@picnixzpicnixz changed the titleDocs: Fixup for PR gh-127054gh-101100: amend references starting with!~ in gh-127054Dec 6, 2024
@koyuki7w
Copy link
ContributorAuthor

@skirpichev The purpose of this change is to suppress sphinx warnings (gh-101100). If the short method names are preferable, I think these should be changed to!append,!pop, etc.

@skirpichev
Copy link
Member

I think these should be changed to !append, !pop, etc.

Ah, indeed. That an option.

koyuki7w reacted with heart emoji

@skirpichevskirpichev added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsDec 6, 2024
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

koyuki7w reacted with heart emoji
@hugovkhugovk merged commit77a61c0 intopython:mainDec 6, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks@koyuki7w for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 6, 2024
… (pythonGH-127684)(cherry picked from commit77a61c0)Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 6, 2024
… (pythonGH-127684)(cherry picked from commit77a61c0)Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@bedevere-app
Copy link

GH-127692 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 6, 2024
@bedevere-app
Copy link

GH-127693 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 6, 2024
hugovk pushed a commit that referenced this pull requestDec 6, 2024
…H-127684) (#127692)gh-101100: amend references starting with `!~` ingh-127054 (GH-127684)(cherry picked from commit77a61c0)Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
hugovk pushed a commit that referenced this pull requestDec 6, 2024
…H-127684) (#127693)gh-101100: amend references starting with `!~` ingh-127054 (GH-127684)(cherry picked from commit77a61c0)Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@koyuki7wkoyuki7w deleted the doc-fix-2 branchDecember 6, 2024 14:25
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@koyuki7w@skirpichev@vstinner@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp