Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127629: Add ctypes to the Emscripten build#127683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
freakboy3742 merged 6 commits intopython:mainfromhoodmane:emscripten-ctypes
Dec 10, 2024

Conversation

@hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedDec 6, 2024•
edited by bedevere-appbot
Loading

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Functionally, this works fine; a couple of questions inline about documentation and gross structure.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hoodmane
Copy link
ContributorAuthor

I have made the requested changes; please review again. Thanks@freakboy3742!

@bedevere-app
Copy link

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks for those fixes - this looks great!

@freakboy3742freakboy3742 merged commit3b18af9 intopython:mainDec 10, 2024
51 of 54 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Adds tooling to build libffi and add ctypes to the stdlib for Emscripten.
export EM_PKG_CONFIG_PATH="$PKG_CONFIG_PATH"

# Specific variables for cross-compilation
export CHOST="wasm32-unknown-linux"# wasm32-unknown-emscripten

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why did this end up beingwasm32-unknown-linux instead ofwasm32-unknown-emscripten?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good question. Maybe I put it that way while debugging and didn't notice before merging.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

+1 more reviewer

@MichaelBuhlerMichaelBuhlerMichaelBuhler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoodmane@freakboy3742@MichaelBuhler
[8]ページ先頭
©2009-2025 Movatter.jp