Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126004: remove redundant safeguards for codecs handlers tests#127680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 5 commits intopython:mainfrompicnixz:fix/codecs/safe-handlers-126004
Jan 23, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedDec 6, 2024•
edited by bedevere-appbot
Loading

@encukou
Copy link
Member

I'd prefer merging this after the 3 fixes; at that point this would add additional assertions andremove thesafe argument.

picnixz reacted with thumbs up emoji

@picnixzpicnixz changed the titlegh-126004: allow to mark codecs handlers tests as safegh-126004: remove safeguards for crashing codecs handlersJan 23, 2025
@picnixzpicnixz changed the titlegh-126004: remove safeguards for crashing codecs handlersgh-126004: remove redundant safeguards for codecs handlersJan 23, 2025
@picnixzpicnixz changed the titlegh-126004: remove redundant safeguards for codecs handlersgh-126004: remove redundant safeguards for codecs handlers testsJan 23, 2025
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

picnixz reacted with thumbs up emoji
@picnixzpicnixz merged commitcf0b2da intopython:mainJan 23, 2025
41 checks passed
@picnixzpicnixz deleted the fix/codecs/safe-handlers-126004 branchJanuary 23, 2025 15:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@encukou@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp