Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-126004: fix positions handling incodecs.replace_errors#127674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 17 commits intopython:mainfrompicnixz:fix/codecs/replace-errors-126004
Jan 23, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedDec 6, 2024
edited by bedevere-appbot
Loading

@picnixzpicnixz requested a review fromencukouJanuary 3, 2025 18:39
@picnixzpicnixz requested a review fromencukouJanuary 22, 2025 11:13
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@picnixzpicnixz merged commit225296c intopython:mainJan 23, 2025
41 checks passed
@picnixzpicnixz deleted the fix/codecs/replace-errors-126004 branchJanuary 23, 2025 10:44
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotiOS ARM64 Simulator 3.x has failed when building commit225296c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/2419) and take a look at the build logs.
  4. Check if the failure is related to this commit (225296c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/2419

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Android 3.x has failed when building commit225296c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/1124) and take a look at the build logs.
  4. Check if the failure is related to this commit (225296c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/1124

Failed tests:

  • test_android

Failed subtests:

  • test_bytes - test.test_android.TestAndroidOutput.test_bytes

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_android.py", line63, inassert_log    line=self.logcat_queue.get(timeout=(deadline- time()))  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/queue.py", line212, ingetraise Empty_queue.EmptyTraceback (most recent call last):  File"/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/runners.py", line118, inrunreturnself._loop.run_until_complete(task)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/base_events.py", line687, inrun_until_completereturn future.result()^^^^^^^^^^^^^^^  File"/Volumes/InternalDisk/Users/android/buildarea/3.x.mhsmith-android-aarch64/build/Android/android.py", line531, inrun_testbedasyncwith asyncio.TaskGroup()as tg:  File"/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line134, in__aexit__raise propagate_cancellation_error  File"/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line110, in__aexit__awaitself._on_completed_futasyncio.exceptions.CancelledErrorTraceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_android.py", line53, insetUpself.assert_log("I", tag, message,skip=True,timeout=5)~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_android.py", line65, inassert_logself.fail(f"line not found:{expected!r}")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:line not found: 'test.test_android.TestAndroidOutput.test_bytes 1737630241.1795416'

@picnixz
Copy link
MemberAuthor

The iOS failures seem unrelated though I cannot confirm and the Android failure may be related so I'll check

@picnixz
Copy link
MemberAuthor

The code that seems to fail is:

self.assertEqual(write_len,stream.write(b))iflinesisNone:lines= [b.decode()]self.assert_logs(level,tag,lines)

However, we're using astrictor abackslashreplace error handler inb.decode() and the logcat process:

defsetUp(self):self.logcat_process=subprocess.Popen(            ["logcat","-v","tag"],stdout=subprocess.PIPE,errors="backslashreplace"        )

so I don't know how it was affected by this change. I'll rerun the build bot for this one and if it still fails, I'll revert the PR.

@picnixz
Copy link
MemberAuthor

!buildbot aarch64 Android 3.x

@bedevere-bot
Copy link

The regex 'aarch64 Android 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@picnixz
Copy link
MemberAuthor

picnixz commentedJan 23, 2025
edited
Loading

Nevermind, the two build bots are actually green on the latest main ¯\_(ツ)_/¯

vstinner reacted with thumbs up emoji

@mhsmith
Copy link
Member

I'm not sure what happened with the iOS buildbot, but the Android failure is a known problem:#124666.

picnixz reacted with heart emoji

@picnixz
Copy link
MemberAuthor

picnixz commentedJan 23, 2025
edited
Loading

Thank you for confirming this. iOS build bot seems to never run so it could be a network issue or build bot issue.

@mhsmith
Copy link
Member

The iOS buildbot had some issues recently (#129200), but it should be back to normal now. This particular failure is one I haven't seen before – it looks like it passed the test suite and then crashed at the end.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@picnixz@bedevere-bot@mhsmith@vstinner@encukou

[8]ページ先頭

©2009-2025 Movatter.jp