Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-127586: properly restore blocked signals in resource_tracker.py#127587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gpshead merged 9 commits intopython:mainfromstephen-hansen:gh-127586-mp-pool-sigblock-fixDec 15, 2024
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
292d37e Correct pthread_sigmask in resource_tracker to restore old signals
stephen-hansen5e4797c Adding NEWS on mp.Pool signal handling
stephen-hansenda95ed3 Fixing mp Pool class path in NEWS
stephen-hansendcc52ba Update Misc/NEWS.d/next/Library/2024-12-03-20-28-08.gh-issue-127586.z…
stephen-hansen2d30d44 Merge branch 'main' into gh-127586-mp-pool-sigblock-fix
stephen-hansen41731d7 Adding resource_tracker blocked signals test
stephen-hansen47e7b67 Linter fix
stephen-hansen070e3e8 Update Lib/test/_test_multiprocessing.py
stephen-hansen82d49e3 fix the test skip
gpsheadFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Linter fix
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit47e7b67bc2be16e881498b2ebe3ca1b4d1add567
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6044,7 +6044,7 @@ def test_resource_tracker_exit_code(self): | ||
| self._test_resource_tracker_leak_resources( | ||
| cleanup=cleanup, | ||
| ) | ||
gpshead marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| def test_resource_tracker_blocked_signals(self): | ||
| # | ||
| # gh-127586: Check that resource_tracker does not override blocked signals of caller. | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.