Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError#127532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 7 commits intopython:mainfromjb2170:gh-127529
Jan 3, 2025

Conversation

@jb2170
Copy link
Contributor

@jb2170jb2170 commentedDec 2, 2024•
edited by bedevere-appbot
Loading

Closes#127529

All good to go.ConnectionAbortedError nowcontinues instead ofreturning. Improves OpenBSD performance. Full writeup in the issue.

I've leftInterruptedError grouped withBlockingIOError to bothreturn early, instead ofInterruptedErrorcontinueing andBlockingIOErrorreturning.PEP-475 should makeInterruptedError never appear right, but hey if it's not broken don't fix it. Best to play it safe with the urgency of signals, especially as asyncio uses them for a wakeup fd.

@jb2170jb2170 changed the titlegh-127529: Correct asyncio.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedErrorgh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedErrorDec 2, 2024
…tLoop._accept_connection's behaviour for handling ConnectionAbortedError
@jb2170
Copy link
ContributorAuthor

jb2170 commentedDec 2, 2024•
edited
Loading

Force pushes to correct typo / my suckiness at reStructuredText

@jb2170
Copy link
ContributorAuthor

@1st1@asvetlov@kumaraditya303@willingc Trivial PR to review + merge before the new year / before it fades out of memory? 🚀

@kumaraditya303
Copy link
Contributor

You need to add tests for this.

…abortederror to test graceful handling of ConnectionAbortedError
@jb2170
Copy link
ContributorAuthor

Hi@kumaraditya303 , thanks for the reply!

I've added a test totest_selector_events.py that checks for the_accept_connection for-loop continuing through aborted connections instead of returning early. The test passes with this PR's changes 😄

@kumaraditya303kumaraditya303enabled auto-merge (squash)January 3, 2025 10:11
@kumaraditya303kumaraditya303 merged commit830e106 intopython:mainJan 3, 2025
44 checks passed
@jb2170jb2170 deleted the gh-127529 branchJanuary 3, 2025 20:17
WolframAlph pushed a commit to WolframAlph/cpython that referenced this pull requestJan 4, 2025
…handling `ConnectionAbortedError` (python#127532)Co-authored-by: Kumar Aditya <kumaraditya@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…handling `ConnectionAbortedError` (python#127532)Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@ambv
Copy link
Contributor

ambv commentedMay 21, 2025•
edited
Loading

@kumaraditya303 don't we want to backport this to 3.13? WDYT?

@emmatyping
Copy link
Member

@kumaraditya303 I think we still need to backport this, right? Looks like it is blocking the 3.13 backport of#134392

@kumaraditya303kumaraditya303 added the needs backport to 3.13bugs and security fixes labelDec 15, 2025
@miss-islington-app
Copy link

Thanks@jb2170 for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 15, 2025
…handling `ConnectionAbortedError` (pythonGH-127532)(cherry picked from commit830e106)Co-authored-by: jb2170 <email@jb2170.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

GH-142738 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 15, 2025
@kumaraditya303
Copy link
Contributor

I think we still need to backport this, right? Looks like it is blocking the 3.13 backport of#134392

Thanks for the reminder, I'll get this and the other one backported.

kumaraditya303 added a commit that referenced this pull requestDec 15, 2025
… handling `ConnectionAbortedError` (GH-127532) (#142738)gh-127529: Correct asyncio's `accept_connection` behaviour for handling `ConnectionAbortedError` (GH-127532)(cherry picked from commit830e106)Co-authored-by: jb2170 <email@jb2170.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asyncio'sBaseSelectorEventLoop._accept_connectionreturns when it shouldcontinue onConnectionAbortedError

4 participants

@jb2170@kumaraditya303@ambv@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp