Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127443: add tool for lintingDoc/data/refcounts.dat#127476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
picnixz wants to merge32 commits intopython:main
base:main
Choose a base branch
Loading
frompicnixz:tools/refcounts/lint-127443

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedDec 1, 2024•
edited
Loading

This tool can be used as follows:

python3.12 Tools/refcounts/lint.py  Doc/data/refcounts.datpython3.12 Tools/refcounts/lint.py  Doc/data/refcounts.dat --abi Misc/stable_abi.toml

With the current file, I have something like: (three were missing in#127451, my bad, so I fixed them as well)

----------------------------------- PARSING ----------------------------------------------------------------------- CHECKING -----------------------------------  643  PyErr_NormalizeException[exc]                      missing reference count management  644  PyErr_NormalizeException[val]                      missing reference count management  645  PyErr_NormalizeException[tb]                       missing reference count managementFound 3 issuesEntries are not sorted

When I also include the stable ABI file, I have in addition (output truncated)

Found 3 issuesEntries are not sorted----------------------------- CHECKING STABLE ABI ------------------------------Stable ABI file: /home/picnix/lib/python/cpython/Misc/stable_abi.tomlMissing 232 stable ABI entries:PyArg_ParsePyArg_ParseTuplePyArg_ParseTupleAndKeywordsPyArg_UnpackTuplePyArg_VaParsePyArg_VaParseTupleAndKeywordsPyArg_ValidateKeywordArgumentsPyBuffer_FromContiguous[...]

erlend-aasland reacted with rocket emoji
@picnixzpicnixzforce-pushed thetools/refcounts/lint-127443 branch frombc45547 to183388fCompareDecember 1, 2024 12:29
@picnixzpicnixz marked this pull request as ready for reviewDecember 2, 2024 11:28
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice. I haven't reviewed the script as I know nothing about therefcounts.dat file, but the lint configs LGTM.

@picnixz
Copy link
MemberAuthor

picnixz commentedDec 2, 2024•
edited
Loading

I don't think I'll change the configs. So thanks Alex for your review (and sorry for the request, I misclicked)! Now, I'll wait for Peter and Kirill's reviews concerning the script itself.

AlexWaygood reacted with thumbs up emoji

@AlexWaygoodAlexWaygood removed their request for reviewDecember 2, 2024 12:10
@picnixzpicnixz added the staleStale PR or inactive for long period of time. labelMar 31, 2025
@picnixz
Copy link
MemberAuthor

Marking it asstale because I still didn't have time to work on the project separately (I'm working on it but I'm advancing slowly)

@picnixzpicnixz marked this pull request as draftMarch 31, 2025 09:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@Eclips4Eclips4Awaiting requested review from Eclips4

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

Assignees
No one assigned
Labels
skip newsstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@picnixz@hugovk@ZeroIntensity@AlexWaygood@Eclips4
[8]ページ先頭
©2009-2025 Movatter.jp