Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127321: Avoid stopping at an opcode without an associated line number for breakpoint()#127457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedNov 30, 2024•
edited by bedevere-appbot
Loading

If we are tracing opcodes (which only happen when we doset_trace() for now), we just step instr again if there's no line number.

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice solution.

@gaogaotiantiangaogaotiantian merged commit1bc4f07 intopython:mainDec 1, 2024
42 checks passed
@gaogaotiantiangaogaotiantian deleted the breakpoint-lineno branchDecember 1, 2024 16:57
@gaogaotiantian
Copy link
MemberAuthor

Ah,@iritkatriel do you think we should backport this to 3.13? It's a bit of behavior change but only happens in rare cases. If not, we should protect all the access tof_lineno because we don't wantpdb to crash when it assumes that's a number.

@iritkatriel
Copy link
Member

I think this is a bug fix, so yes.

@gaogaotiantiangaogaotiantian added the needs backport to 3.13bugs and security fixes labelDec 1, 2024
@miss-islington-app
Copy link

Thanks@gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@gaogaotiantian, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 1bc4f076d193ad157bdc69a1d62685a15f95113f 3.13

gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull requestDec 1, 2024
…ated line number for breakpoint() (pythonGH-127457)(cherry picked from commit1bc4f07)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

GH-127487 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 1, 2024
@bedevere-app
Copy link

GH-127487 is a backport of this pull request to the3.13 branch.

@iritkatrieliritkatriel added the type-bugAn unexpected behavior, bug, or error labelDec 1, 2024
gaogaotiantian added a commit that referenced this pull requestDec 1, 2024
picnixz pushed a commit to picnixz/cpython that referenced this pull requestDec 2, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

@gaogaotiantiangaogaotiantian

Labels
type-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@gaogaotiantian@iritkatriel
[8]ページ先頭
©2009-2025 Movatter.jp