Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Fix type hints in summarize stats#127453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We might want to consider running mypy as a part of lint on this in the future, but I doubt it's ready for it's aggressiveness, even with this change. LGTM.
I thinkthis TODO can also be deleted, can we do it in this PR or should I open another one just for that? |
You can open another PR, let's keep this one focused on type hints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks for doing this.
Sure, |
@ZeroIntensity Fixing type hints in summarize stats