Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-127429: fix sysconfig data generation on cross-builds#127430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FFY00 merged 12 commits intopython:mainfromFFY00:gh-127429
Dec 2, 2024

Conversation

FFY00
Copy link
Member

@FFY00FFY00 commentedNov 29, 2024•
edited by bedevere-appbot
Loading

Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

@nascheme, thisshould fix the JIT tests.

Signed-off-by: Filipe Laíns <lains@riseup.net>
…ts :)Signed-off-by: Filipe Laíns <lains@riseup.net>
…pilingSigned-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

FFY00 commentedNov 30, 2024•
edited
Loading

Alright, the tests seem to be passing 😄

@FFY00
Copy link
MemberAuthor

Okay, there seems to be an issue still:

======================================================================ERROR: test_sysconfigdata_json (test.test_sysconfig.TestSysConfig.test_sysconfigdata_json)----------------------------------------------------------------------Traceback (most recent call last):  File "/home/runner/work/cpython/cpython/Lib/test/test_sysconfig.py", line 644, in test_sysconfigdata_json    with open(json_data_path) as f:         ~~~~^^^^^^^^^^^^^^^^FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/cpython/cpython/build/lib.linux-aarch64-3.14-pydebug/_sysconfig_vars_d_linux_aarch64-linux-gnu.json'----------------------------------------------------------------------

@FFY00

This comment was marked as outdated.

Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

It seems like_get_pybuilddir was using a runtime check, which reflected the host on cross-builds.

Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

Oh, yay, all tests pass, that wasn't much fun to debug 😅

@FFY00FFY00 merged commit2950bc5 intopython:mainDec 2, 2024
57 checks passed
@FFY00FFY00 deleted the gh-127429 branchDecember 2, 2024 07:12
@miss-islington-app
Copy link

Thanks@FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@FFY00, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 2950bc50af8fc2539e64731359bfb39b335a614d 3.13

@miss-islington-app
Copy link

Sorry,@FFY00, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 2950bc50af8fc2539e64731359bfb39b335a614d 3.12

@hugovk
Copy link
Member

@FFY00 Triage: please could you make the backports if they're still needed? Otherwise let's remove the labels.

hugovk pushed a commit to hugovk/cpython that referenced this pull requestMar 6, 2025
…pythonGH-127430)(cherry picked from commit2950bc5)Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
@@ -161,7 +162,7 @@ def _print_config_dict(d, stream):

def _get_pybuilddir():
pybuilddir = f'build/lib.{get_platform()}-{get_python_version()}'
ifhasattr(sys, "gettotalrefcount"):
ifget_config_var('Py_DEBUG') == '1':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

get_config_var('Py_DEBUG') is anint rather thanstr.

XuehaiPan added a commit to XuehaiPan/cpython that referenced this pull requestApr 1, 2025
@hugovkhugovk removed the needs backport to 3.12only security fixes labelApr 8, 2025
@hugovkhugovk removed the needs backport to 3.13bugs and security fixes labelMay 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@XuehaiPanXuehaiPanXuehaiPan left review comments

@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

@FFY00FFY00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@FFY00@hugovk@XuehaiPan
[8]ページ先頭
©2009-2025 Movatter.jp